From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED9F5C3A59F for ; Thu, 29 Aug 2019 14:38:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C36C723404 for ; Thu, 29 Aug 2019 14:38:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728051AbfH2OiZ (ORCPT ); Thu, 29 Aug 2019 10:38:25 -0400 Received: from smtp1.de.adit-jv.com ([93.241.18.167]:34308 "EHLO smtp1.de.adit-jv.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727985AbfH2OiZ (ORCPT ); Thu, 29 Aug 2019 10:38:25 -0400 Received: from localhost (smtp1.de.adit-jv.com [127.0.0.1]) by smtp1.de.adit-jv.com (Postfix) with ESMTP id 19BEC3C057C; Thu, 29 Aug 2019 16:38:23 +0200 (CEST) Received: from smtp1.de.adit-jv.com ([127.0.0.1]) by localhost (smtp1.de.adit-jv.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e8BMcyfaoqr8; Thu, 29 Aug 2019 16:38:17 +0200 (CEST) Received: from HI2EXCH01.adit-jv.com (hi2exch01.adit-jv.com [10.72.92.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp1.de.adit-jv.com (Postfix) with ESMTPS id A18393C0579; Thu, 29 Aug 2019 16:38:17 +0200 (CEST) Received: from vmlxhi-102.adit-jv.com (10.72.93.184) by HI2EXCH01.adit-jv.com (10.72.92.24) with Microsoft SMTP Server (TLS) id 14.3.468.0; Thu, 29 Aug 2019 16:38:17 +0200 Date: Thu, 29 Aug 2019 16:38:14 +0200 From: Eugeniu Rosca To: "George G. Davis" CC: Shuah Khan , Jerry Hoemann , Colin Ian King , "open list:KERNEL SELFTEST FRAMEWORK" , open list , Eugeniu Rosca , Eugeniu Rosca Subject: Re: [PATCH] selftests: watchdog: Add optional file argument Message-ID: <20190829143814.GA3424@vmlxhi-102.adit-jv.com> References: <1567053566-18971-1-git-send-email-george_davis@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1567053566-18971-1-git-send-email-george_davis@mentor.com> User-Agent: Mutt/1.12.1+40 (7f8642d4ee82) (2019-06-28) X-Originating-IP: [10.72.93.184] Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Hi George, On Thu, Aug 29, 2019 at 12:39:25AM -0400, George G. Davis wrote: > Some systems have multiple watchdog devices where the first device > registered is assigned to the /dev/watchdog device file. Confirmed on R-Car H3-Salvator-X: root@rcar-gen3:~# ls -al /dev/watchdog* crw------- 1 root root 10, 130 Aug 21 09:38 /dev/watchdog crw------- 1 root root 247, 0 Aug 21 09:38 /dev/watchdog0 [..] > - fd = open("/dev/watchdog", O_WRONLY); > + while ((c = getopt_long(argc, argv, sopts, lopts, NULL)) != -1) { > + if (c == 'f') > + file = optarg; > + } > + > + fd = open(file, O_WRONLY); Would it be possible to improve below not so helpful and slightly misleading printout: $ ./watchdog-test -d -t 10 -p 5 -e -f /dev/watch Watchdog device not enabled. Thanks! -- Best Regards, Eugeniu.