From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0A35C10F14 for ; Thu, 10 Oct 2019 09:30:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BDBDF2064A for ; Thu, 10 Oct 2019 09:30:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387715AbfJJJaO (ORCPT ); Thu, 10 Oct 2019 05:30:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:52238 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727320AbfJJJaO (ORCPT ); Thu, 10 Oct 2019 05:30:14 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8B853B179; Thu, 10 Oct 2019 09:30:12 +0000 (UTC) Date: Thu, 10 Oct 2019 11:30:11 +0200 From: Cyril Hrubis To: Dmitry Vyukov Cc: Richard Palethorpe , syzkaller , kernelci@groups.io, shuah , ltp@lists.linux.it, George Kennedy , Cyril Hrubis , "open list : KERNEL SELFTEST FRAMEWORK" , automated-testing@yoctoproject.org Subject: Re: [RFC PATCH] LTP Wrapper for Syzkaller reproducers Message-ID: <20191010093011.GA2508@rei.lan> References: <20191009142446.6997-1-rpalethorpe@suse.com> <20191009145416.GA5014@rei.lan> <20191009180447.GD15291@rei.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Hi! > > > > Indeed, it's removed recursively by the test library. > > > > > > :popcorn: > > > > > > It took me several years to figure out how to more or less reliably > > > remove dirs after the fuzzer ;) > > > (no, unlink won't do ;)) > > > > I guess that there are things such as immutable file attributes that has > > to be cleared and many more. Do you have piece of code somewhere that we > > can look into to spare us from reinventing the wheel? > > Here is what we have: > https://github.com/google/syzkaller/blob/c4b9981b5f5b70dc03eb3f76c618398510101a1d/executor/common_linux.h#L2358-L2461 > Maybe it can be simplified, but that's what we ended up with after > some organic evolution. At least the comments may give some hints as > to what may go wrong. Thanks a lot! Also I see that you are using namespaces, and much more, to sandbox the fuzzer, I was wondering if we should do that, at least separate user and pid namespace sounds like a good idea to me. -- Cyril Hrubis chrubis@suse.cz