From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04D88FA3728 for ; Wed, 16 Oct 2019 14:25:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D21A021A49 for ; Wed, 16 Oct 2019 14:25:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727451AbfJPOZH (ORCPT ); Wed, 16 Oct 2019 10:25:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:55464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726750AbfJPOZH (ORCPT ); Wed, 16 Oct 2019 10:25:07 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1D3D0218DE; Wed, 16 Oct 2019 14:25:06 +0000 (UTC) Date: Wed, 16 Oct 2019 10:25:04 -0400 From: Steven Rostedt To: Miroslav Benes Cc: mingo@redhat.com, jpoimboe@redhat.com, jikos@kernel.org, pmladek@suse.com, joe.lawrence@redhat.com, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, shuah@kernel.org, kamalesh@linux.vnet.ibm.com, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 1/3] ftrace: Introduce PERMANENT ftrace_ops flag Message-ID: <20191016102504.274fc88d@gandalf.local.home> In-Reply-To: <20191016094853.3913f5ae@gandalf.local.home> References: <20191016113316.13415-1-mbenes@suse.cz> <20191016113316.13415-2-mbenes@suse.cz> <20191016094853.3913f5ae@gandalf.local.home> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Wed, 16 Oct 2019 09:48:53 -0400 Steven Rostedt wrote: > @@ -6796,10 +6798,12 @@ ftrace_enable_sysctl(struct ctl_table *table, int write, > > ret = proc_dointvec(table, write, buffer, lenp, ppos); As you just stated on IRC, the update to ftrace_enabled gets updated in the above routine. I forgot about this :-/ (Senior moment) I guess there's nothing to worry about here. -- Steve > > - if (ret || !write || (last_ftrace_enabled == !!ftrace_enabled)) > + if (ret || !write || (ftrace_enabled == !!sysctl_ftrace_enabled)) > goto out; >