Re: [PATCH v7 01/24] mm/gup: pass flags arg to __gup_device_* functions

John Hubbard
2019-11-21T08:28:14Z

On 11/21/19 12:06 AM, Christoph Hellwig wrote:
> On Wed, Nov 20, 2019 at 11:13:31PM -0800, John Hubbard wrote:
>> A subsequent patch requires access to gup flags, so
>> pass the flags argument through to the __gup_device_*
>> functions.
>
> Looks fine, but why not fold this into the patch using the flags.

Yes, I'll do that.

>
> Also you can use up your full 73 chars per line in the commit log.
>

OK.

thanks,
--
John Hubbard
NVIDIA