From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C45DEC432C0 for ; Tue, 26 Nov 2019 17:24:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 998B1207DD for ; Tue, 26 Nov 2019 17:24:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727925AbfKZRYG (ORCPT ); Tue, 26 Nov 2019 12:24:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:60014 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727674AbfKZRYG (ORCPT ); Tue, 26 Nov 2019 12:24:06 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 426E8206BF; Tue, 26 Nov 2019 17:24:05 +0000 (UTC) Date: Tue, 26 Nov 2019 12:24:03 -0500 From: Steven Rostedt To: Masami Hiramatsu Cc: Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [BUGFIX PATCH v4 1/4] selftests/ftrace: Fix to check the existence of set_ftrace_filter Message-ID: <20191126122403.79705b9e@gandalf.local.home> In-Reply-To: <157475725551.3389.16908546371847626653.stgit@devnote2> References: <157475724667.3389.15752644047898709246.stgit@devnote2> <157475725551.3389.16908546371847626653.stgit@devnote2> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Tue, 26 Nov 2019 17:34:16 +0900 Masami Hiramatsu wrote: > If we run ftracetest on the kernel with CONFIG_DYNAMIC_FTRACE=n, > there is no set_ftrace_filter and all test cases are failed, because > reset_ftrace_filter() returns an error. > Let's check whether set_ftrace_filter exists in reset_ftrace_filter() > and clean up only set_ftrace_notrace in initialize_ftrace(). > > > Signed-off-by: Masami Hiramatsu Reviewed-by: Steven Rostedt (VMware) -- Steve