From: Chris Down <chris@chrisdown.name>
To: Roman Gushchin <guro@fb.com>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH kselftest-next 1/2] kselftests: memcg: update the oom group leaf events test
Date: Tue, 3 Dec 2019 11:57:58 -0500 [thread overview]
Message-ID: <20191203165758.GA607734@chrisdown.name> (raw)
In-Reply-To: <20191202234212.4134802-1-guro@fb.com>
Roman Gushchin writes:
>Commit 9852ae3fe529 ("mm, memcg: consider subtrees in memory.events") made
>memory.events recursive: all events are propagated upwards by the
>tree. It was a change in semantics.
>
>It broke the oom group leaf events test: it assumes that after
>an OOM the oom_kill counter is zero on parent's level.
>
>Let's adjust the test: it should have similar expectations
>for the child and parent levels.
>
>The test passes after this fix.
Thanks! Hopefully b59b1baa will also avoid this going unnoticed in future.
Reviewed-by: Chris Down <chris@chrisdown.name>
prev parent reply other threads:[~2019-12-03 16:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 23:42 [PATCH kselftest-next 1/2] kselftests: memcg: update the oom group leaf events test Roman Gushchin
2019-12-02 23:42 ` [PATCH kselftest-next 2/2] kselftests: memcg: speed up the memory.high test Roman Gushchin
2019-12-03 16:58 ` Chris Down
2019-12-03 16:57 ` Chris Down [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203165758.GA607734@chrisdown.name \
--to=chris@chrisdown.name \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox