From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C46DEC3F2CD for ; Mon, 2 Mar 2020 23:02:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9445921739 for ; Mon, 2 Mar 2020 23:02:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FPSeLrB7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726785AbgCBXCI (ORCPT ); Mon, 2 Mar 2020 18:02:08 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:39039 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726752AbgCBXCI (ORCPT ); Mon, 2 Mar 2020 18:02:08 -0500 Received: by mail-pf1-f195.google.com with SMTP id l7so442647pff.6 for ; Mon, 02 Mar 2020 15:02:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=alU+BgvFGo59yM0O+ldee5pOjl7Ty1NQ+17QZiMtzMo=; b=FPSeLrB7GcxGD/0n0DkgZRMYdBUiZeQ+laPMlp2Pb3icU44iK9eIgS7nJheSVzUk4x XzQrD4vw1cKLDfSG7T4p+rZUN5/fWPWf5odYIvQHZz0B3JCIvnVMia0pRtb1FtCenogk e82T6ScsKsm8DbFN0db3OAll3/2xdOIMdHVxU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=alU+BgvFGo59yM0O+ldee5pOjl7Ty1NQ+17QZiMtzMo=; b=LnxLOOTTenXsEQ26WQpWBe3dJUjQ8FHZ5vWRIi1lq77a/p9yKMJ/Jdc/mVn1nVdFDq 9juLvcO95SxzFdWg1rJN+432faG1GgdsgOsr9j3y6ElmdIfkTLMfxWiM+5j75pPZdhDi pukfhSfMJFKqOXbr4mCslp+Y+MCh+EjOnd2Gm9+QIxfgc/ZY4f3nJmqRxGZ95v8Yidtw tSQp8/RMigE6wy3eV7DsJ2zuHNC+HXxTIOcP3lU9WimwanTg+iJjacpddd1Zs41Vtzuo fDzlphZZPyt/yYEFmwfPj3m2SA3//Ctt9rUGEFx8Tce9RJ9eM1qEmY+bfg+bo991ujZ7 3eDA== X-Gm-Message-State: ANhLgQ0GYASJAmA9y2szN3sUgFXeP3TR119TLtY8qPY4ktwZ4XWx5eMa gunAEOm75V1VZtXC7w5nEwKITg== X-Google-Smtp-Source: ADFU+vvaMShTu4H+Bx5ShEjs077RseA1NzW7/myf8UYsI/g5oF2fIvhSkSOhJhD1EMHTIgkyXbQ4Ug== X-Received: by 2002:aa7:8bc1:: with SMTP id s1mr1226128pfd.215.1583190127144; Mon, 02 Mar 2020 15:02:07 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id v29sm22024356pgc.72.2020.03.02.15.02.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2020 15:02:06 -0800 (PST) Date: Mon, 2 Mar 2020 15:02:05 -0800 From: Kees Cook To: Brendan Higgins Cc: Dmitry Vyukov , Patricia Alfonso , Andrey Ryabinin , David Gow , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , LKML , kasan-dev , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development Subject: Re: [RFC PATCH 1/2] Port KASAN Tests to KUnit Message-ID: <202003021500.9E0FEE1BEF@keescook> References: <20200227024301.217042-1-trishalfonso@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Mon, Mar 02, 2020 at 02:36:48PM -0800, Brendan Higgins wrote: > On Mon, Mar 2, 2020 at 9:52 AM Kees Cook wrote: > > I'm all for unittests (I have earlier kind-of-unit-tests in > > lib/test_user_copy.c lib/test_overflow.c etc), but most of LKDTM is > > > > I took a brief look at lib/test_user_copy.c, it looks like it doesn't > use TAP formatted output. How do you feel about someone converting > them over to use KUnit? If nothing else, it would be good getting all > the unit-ish tests to output in the same format. > > I proposed converting over some of the runtime tests over to KUnit as > a LKMP project (Linux Kernel Mentorship Program) here: > > https://wiki.linuxfoundation.org/lkmp/lkmp_project_list#convert_runtime_tests_to_kunit_tests > > I am curious what you think about this. > > Yes please! Anything that helps these tests get more exposure/wider testing is good. (That said, I don't want to lose any of the existing diagnostic messages -- _adding_ TAP would be lovely.) -- Kees Cook