From: Christoph Hellwig <hch@lst.de>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: "Ralph Campbell" <rcampbell@nvidia.com>,
"Christoph Hellwig" <hch@lst.de>,
"Dan Williams" <dan.j.williams@intel.com>,
"Bharata B Rao" <bharata@linux.ibm.com>,
"Christian König" <christian.koenig@amd.com>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Jerome Glisse" <jglisse@redhat.com>,
kvm-ppc@vger.kernel.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 3/4] mm: simplify device private page handling in hmm_range_fault
Date: Sat, 21 Mar 2020 09:20:41 +0100 [thread overview]
Message-ID: <20200321082041.GA28613@lst.de> (raw)
In-Reply-To: <20200320000345.GO20941@ziepe.ca>
On Thu, Mar 19, 2020 at 09:03:45PM -0300, Jason Gunthorpe wrote:
> > Should tests enable the feature or the feature enable the test?
> > IMHO, if the feature is being compiled into the kernel, that should
> > enable the menu item for the test. If the feature isn't selected,
> > no need to test it :-)
>
> I ment if DEVICE_PRIVATE should be a user selectable option at all, or
> should it be turned on when a driver like nouveau is selected.
I don't think it should be user selectable. This is an implementation
detail users can't know about.
> Is there some downside to enabling DEVICE_PRIVATE?
The option itself adds a little more code to the core kernel, and
introduces a few additional branches in core mm code.
But more importantly it pulls in the whole pgmap infrastructure.
prev parent reply other threads:[~2020-03-21 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200316193216.920734-1-hch@lst.de>
[not found] ` <20200316193216.920734-4-hch@lst.de>
[not found] ` <7256f88d-809e-4aba-3c46-a223bd8cc521@nvidia.com>
[not found] ` <20200317121536.GQ20941@ziepe.ca>
[not found] ` <20200317122445.GA11662@lst.de>
[not found] ` <20200317122813.GA11866@lst.de>
[not found] ` <20200317124755.GR20941@ziepe.ca>
[not found] ` <20200317125955.GA12847@lst.de>
[not found] ` <24fca825-3b0f-188f-bcf2-fadcf3a9f05a@nvidia.com>
[not found] ` <20200319181716.GK20941@ziepe.ca>
2020-03-19 22:56 ` [PATCH 3/4] mm: simplify device private page handling in hmm_range_fault Ralph Campbell
2020-03-20 0:03 ` Jason Gunthorpe
2020-03-21 8:20 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200321082041.GA28613@lst.de \
--to=hch@lst.de \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bharata@linux.ibm.com \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=dan.j.williams@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rcampbell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox