Re: [PATCH] selftests/exec: Add binfmt_script regression test

[Kees Cook <keescook@chromium.org>]

On Mon, Jun 15, 2020 at 03:41:54PM +0000, patchwork-bot+linux-kselftest@kernel.org wrote:
> Hello:
> 
> This patch was applied to shuah/linux-kselftest.git (refs/heads/next).

Hi! Thanks for snagging this, however, see below...

> 
> On Wed, 20 May 2020 02:05:56 -0700 you wrote:
> > While working on commit b5372fe5dc84 ("exec: load_script: Do not exec
> > truncated interpreter path"), I wrote a series of test scripts to verify
> > corner cases. However, soon after, commit 6eb3c3d0a52d ("exec: increase
> > BINPRM_BUF_SIZE to 256") landed, resulting in the tests needing to be
> > refactored for the larger BINPRM_BUF_SIZE, which got lost on my TODO
> > list. During the recent exec refactoring work[1], the need for these tests
> > resurfaced, so I've finished them up for addition to the kernel selftests.
> > 
> > [...]
> 
> 
> Here is a summary with links:
>   - selftests/exec: Add binfmt_script regression test
>     https://git.kernel.org/shuah/linux-kselftest/c/b081320f0693cce0394f7c8bad9fba0b25982186
> 
> You are awesome, thank you!

This was already picked up by Eric for this execve series, and has
already landed in Linus's tree as b081320f0693cce0394f7c8bad9fba0b25982186

-- 
Kees Cook