From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A84BC433DF for ; Thu, 2 Jul 2020 19:44:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0DC8206E2 for ; Thu, 2 Jul 2020 19:44:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725954AbgGBTox (ORCPT ); Thu, 2 Jul 2020 15:44:53 -0400 Received: from mga18.intel.com ([134.134.136.126]:5385 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725937AbgGBTox (ORCPT ); Thu, 2 Jul 2020 15:44:53 -0400 IronPort-SDR: 1t0tLXLFVra7Tc12dqK9rZ3OAKEKe2oE/MA6/JsncQJROVljLKxlXd56GM8N2is1HXjz09kZZz 0LFGbbbWQUBQ== X-IronPort-AV: E=McAfee;i="6000,8403,9670"; a="134474655" X-IronPort-AV: E=Sophos;i="5.75,305,1589266800"; d="scan'208";a="134474655" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2020 12:44:52 -0700 IronPort-SDR: Zywr3ldWei8/LIeUJeTPM6lvkCxsULkQd9GBaC0hsSX9Jgx0hUtKk1vrwZa3EodiWQXny9irbt ClkuoJnM9zbg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,305,1589266800"; d="scan'208";a="387429233" Received: from frichard-mobl.ger.corp.intel.com (HELO localhost) ([10.249.44.59]) by fmsmga001.fm.intel.com with ESMTP; 02 Jul 2020 12:44:49 -0700 Date: Thu, 2 Jul 2020 22:44:48 +0300 From: Jarkko Sakkinen To: Pengfei Xu , Shuah Khan Cc: Qiuxu Zhuo , Heng Su , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Kai Svahn Subject: Re: [PATCH v4] selftests: tpm: upgrade TPM2 tests from Python 2 to Python 3 Message-ID: <20200702194435.GA28988@linux.intel.com> References: <20200626034052.25263-1-pengfei.xu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200626034052.25263-1-pengfei.xu@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Fri, Jun 26, 2020 at 11:40:52AM +0800, Pengfei Xu wrote: > Python 2 is no longer supported by the Python upstream project, so > upgrade TPM2 tests to Python 3. > > Signed-off-by: Pengfei Xu I think that it's perfect now. Thank you. Also 1. I checked that scripts/checkpatch.pl did not report any errors. 2. sudo python3 -m unittest -v tpm2_tests.SmokeTest 3. sudo python3 -m unittest -v tpm2_tests.SpaceTest Reviewed-by: Jarkko Sakkinen Tested-by: Jarkko Sakkinen Shuah, I could pick this up after your PR (with my earlier fixes) lands to mainline, and sort out possible merge conflicts if they uprise. Is this fine by you? /Jarkko