From: Paolo Bonzini <pbonzini@redhat.com>
To: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Cc: christian@brauner.io, shuah@kernel.org
Subject: [PATCH v3 0/2] selftests: pidfd: prefer ksft_test_result_skip to ksft_exit_*
Date: Tue, 7 Jul 2020 06:19:34 -0400 [thread overview]
Message-ID: <20200707101936.12052-1-pbonzini@redhat.com> (raw)
Calling ksft_exit_* results in executing fewer tests than planned, which
is wrong for ksft_exit_skip or suboptimal (because it results in a bail
out) for ksft_exit_fail_msg.
Using ksft_test_result_skip instead skips only one test and lets the
test plan proceed as promised by ksft_set_plan.
Paolo
Paolo Bonzini (2):
selftests: pidfd: do not use ksft_exit_skip after ksft_set_plan
selftests: pidfd: skip test if unshare fails with EPERM
tools/testing/selftests/pidfd/pidfd_test.c | 55 ++++++++++++++++++----
1 file changed, 46 insertions(+), 9 deletions(-)
--
2.26.2
next reply other threads:[~2020-07-07 10:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 10:19 Paolo Bonzini [this message]
2020-07-07 10:19 ` [PATCH v3 1/2] selftests: pidfd: do not use ksft_exit_skip after ksft_set_plan Paolo Bonzini
2020-07-07 15:24 ` Shuah Khan
2020-07-07 10:19 ` [PATCH v3 2/2] selftests: pidfd: skip test if unshare fails with EPERM Paolo Bonzini
2020-07-07 13:52 ` [PATCH v3 0/2] selftests: pidfd: prefer ksft_test_result_skip to ksft_exit_* Christian Brauner
2020-07-07 14:47 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707101936.12052-1-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=christian@brauner.io \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).