Re: [PATCH v2 0/6] selftests: arm64: Add floating point selftests

[Dave Martin <Dave.Martin@arm.com>]

On Tue, Sep 01, 2020 at 02:21:59PM +0100, Will Deacon wrote:
> On Mon, Aug 31, 2020 at 03:45:46PM -0600, Shuah Khan wrote:
> > On 8/19/20 5:48 AM, Mark Brown wrote:
> > > This series imports a series of tests for FPSIMD and SVE originally
> > > written by Dave Martin to the tree. Since these extensions have some
> > > overlap in terms of register usage and must sometimes be tested together
> > > they're dropped into a single directory. I've adapted some of the tests
> > > to run within the kselftest framework but there are also some stress
> > > tests here that are intended to be run as soak tests so aren't suitable
> > > for running by default and are mostly just integrated with the build
> > > system. There doesn't seem to be a more suitable home for those stress
> > > tests and they are very useful for work on these areas of the code so it
> > > seems useful to have them somewhere in tree.
> > > 
> > > v2: Rebased onto v5.9-rc1
> > > 
> > > Mark Brown (6):
> > >    selftests: arm64: Test case for enumeration of SVE vector lengths
> > >    selftests: arm64: Add test for the SVE ptrace interface
> > >    selftests: arm64: Add stress tests for FPSMID and SVE context
> > >      switching
> > >    selftests: arm64: Add utility to set SVE vector lengths
> > >    selftests: arm64: Add wrapper scripts for stress tests
> > >    selftests: arm64: Add build and documentation for FP tests
> > 
> > Patches look good to me from selftests perspective. My acked by
> > for these patches to go through arm64.
> > 
> > Acked-by: Shuah Khan <skhan@linuxfoundation.org>
> 
> Thanks, Shuah.
> 
> > If you would like me to take these through kselftest tree, give
> > me your Acks. I can queue these up for 5.10-rc1
> 
> Given there are a few arm64 kselftests series pending at the moment, I'll
> queue them in the arm64 tree, but on their own branch in case you end up
> needing to pull it in as well. I'll drop you a note once I've done that
> (I'm just starting to queue stuff this week).
> 
> Will

FWIW,

Acked-by: Dave Martin <Dave.Martin@arm.com>

I haven't gone through the integration in detail, but nothing leaps out
as disastrously wrong.


I'm not sure how useful these tests are to people in general, but
they've been valuable for maintaining the FP context switch code on
arm64.  I think it makes sense to keep them alongside the kernel so that
they don't get get lost.

Cheers
---Dave