From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: David Gow <davidgow@google.com>,
linux-kselftest@vger.kernel.org,
Brendan Higgins <brendanhiggins@google.com>,
kunit-dev@googlegroups.com
Subject: Re: [PATCH v1] lib/test_list: Follow existing pattern for a file name
Date: Thu, 15 Oct 2020 21:28:51 +0300 [thread overview]
Message-ID: <20201015182851.GB4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201015135908.36628-1-andriy.shevchenko@linux.intel.com>
On Thu, Oct 15, 2020 at 04:59:08PM +0300, Andy Shevchenko wrote:
> Test in lib/ either KUnit or not are named in the same pattern,
> i.e. test_*.c, except few ones. Rename list-test.c to test_list.c
> to follow this pattern.
>
> Note, current documentation doesn't specify any file name conventions,
> and we glad to stick with a current one in the subsystem.
Okay, according to new convention it should be either _test or _kunit. Still
not clear where to put it. New convention tell about nearby to the module it
tests, but this is header file!
Please, update documentation accordingly.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-10-15 18:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 13:59 [PATCH v1] lib/test_list: Follow existing pattern for a file name Andy Shevchenko
2020-10-15 18:28 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015182851.GB4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox