Re: [PATCH v3 03/21] selftests/resctrl: Fix typo in help text

Shuah Khan
2020-10-27T20:58:32Z

On 10/20/20 5:51 PM, Fenghua Yu wrote:
> From: Reinette Chatre <reinette.chatre@intel.com>
>
> Add a missing newline to the help text printed and fixup the next line
> to line it up to previous line for improved readability.
>
> Fixes: 78941183d1b1 ("selftests/resctrl: Add Cache QoS Monitoring (CQM) selftest")
> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> ---
> tools/testing/selftests/resctrl/resctrl_tests.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
> index 35a91cab1b88..b2a560c0c5dc 100644
> --- a/tools/testing/selftests/resctrl/resctrl_tests.c
> +++ b/tools/testing/selftests/resctrl/resctrl_tests.c
> @@ -37,8 +37,8 @@ void detect_amd(void)
> static void cmd_help(void)
> {
> printf("usage: resctrl_tests [-h] [-b \"benchmark_cmd [options]\"] [-t test list] [-n no_of_bits]\n");
> - printf("\t-b benchmark_cmd [options]: run specified benchmark for MBM, MBA and CMT");
> - printf("\t default benchmark is builtin fill_buf\n");
> + printf("\t-b benchmark_cmd [options]: run specified benchmark for MBM, MBA and CMT\n");
> + printf("\t default benchmark is builtin fill_buf\n");
> printf("\t-t test list: run tests specified in the test list, ");
> printf("e.g. -t mbm, mba, cmt, cat\n");
> printf("\t-n no_of_bits: run cache tests using specified no of bits in cache bit mask\n");
>

The commit summary is misleading. It isn't typo. You are adding
a space to make the message correct?

thanks,
-- Shuah