From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4016BC55178 for ; Sat, 24 Oct 2020 01:31:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 079FF24641 for ; Sat, 24 Oct 2020 01:31:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603503085; bh=3bvdQpcDajIOAP+NZa60PaBpOWVSUIRRs73iCB/PJYg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=vFNraKZckV3eZfIZI4UOdORRMcYf/iDsieLIdFo/A+CXyPqZFtHZa/D936dS6ht4b F50ypLndJsnTBRIGZx56j00HkoDwRObkhFXQsC/0tpqDS9d+9vqKBG+5So7B0T39MF 41d4d1xMC5Xd11TT6X0FaeWtdqhude8RgIwqGjn4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759114AbgJXBbC (ORCPT ); Fri, 23 Oct 2020 21:31:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:35110 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758421AbgJXBbC (ORCPT ); Fri, 23 Oct 2020 21:31:02 -0400 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3605924248; Sat, 24 Oct 2020 01:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603503077; bh=3bvdQpcDajIOAP+NZa60PaBpOWVSUIRRs73iCB/PJYg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VJUuzDMyLzhSfjNDGnzhTiRlYAJygQ/WpGw+lktpMqgGFJ4vREbf0tzwRqvCNARyX RTQjhCmSQ2v7r0dRb4dSrUAZ3NHGoLu+81ygMn80B2WQYanEcxkOeuZd4blB8xwuxH 85GJL0KHhX2ffLQk/i048N6ieHn/9Z5XM8wAgnVo= Date: Sat, 24 Oct 2020 10:31:12 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: Alexander Gordeev , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Brauner , Masami Hiramatsu Subject: Re: [PATCH] selftests/ftrace: remove _do_fork() leftovers Message-Id: <20201024103112.64372203e6729279e9ef92f5@kernel.org> In-Reply-To: <20201023093523.65c495f8@gandalf.local.home> References: <1603443123-17457-1-git-send-email-agordeev@linux.ibm.com> <20201023093523.65c495f8@gandalf.local.home> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Fri, 23 Oct 2020 09:35:23 -0400 Steven Rostedt wrote: > On Fri, 23 Oct 2020 10:52:03 +0200 > Alexander Gordeev wrote: > > > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-notrace-pid.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-notrace-pid.tc > > index acb17ce..0ddb948 100644 > > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-notrace-pid.tc > > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-notrace-pid.tc > > @@ -39,7 +39,7 @@ do_test() { > > disable_tracing > > > > echo do_execve* > set_ftrace_filter > > - echo *do_fork >> set_ftrace_filter > > + echo kernel_clone >> set_ftrace_filter > > > > echo $PID > set_ftrace_notrace_pid > > echo function > current_tracer > > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc > > index 9f0a968..71319b3 100644 > > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc > > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc > > @@ -39,7 +39,7 @@ do_test() { > > disable_tracing > > > > echo do_execve* > set_ftrace_filter > > - echo *do_fork >> set_ftrace_filter > > + echo kernel_clone >> set_ftrace_filter > > > > echo $PID > set_ftrace_pid > > echo function > current_tracer > > The issue I have with this, is that I run these tests on older kernels too, > and tests that use to work on older kernels should still work. In fact, > this fails on the kernel I'm currently adding new changes to! > > Perhaps we should have: > > # older kernels have do_fork, but newer kernels have kernel_clone > echo kernel_clone >> set_ftrace_filter || echo *do_fork >> set_ftrace_filter Good catch. BTW, can we check the filter-bility by grep the pattern from set_ftrace_filter? Thank you, -- Masami Hiramatsu