From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ADAFC2D0A3 for ; Mon, 2 Nov 2020 21:25:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F01C0208A9 for ; Mon, 2 Nov 2020 21:25:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AWgpB5KP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726716AbgKBVZK (ORCPT ); Mon, 2 Nov 2020 16:25:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:52386 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725940AbgKBVZH (ORCPT ); Mon, 2 Nov 2020 16:25:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604352306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2Snpjj32EZfd5zmVNHpW7WN3b1s9Tl7X56oVsWAnz9o=; b=AWgpB5KPhu0LDr3wYpiBNFvlMN262ty29Xld/f1KZCPmQcmWoJQrdfTMJoWx1gMdjU5XB/ JGxgz/gJ8dcbhoL70+e+Wd3KTEHWXLR+cCrnxZy2AHCFZCHay2an0+6sUc00OLv6gyO3yp 85Yoas5NBn5WhSTGe9yVI/Tsarh9sBk= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-69-SzJzWLRANaeprjDqOBZFyA-1; Mon, 02 Nov 2020 16:25:04 -0500 X-MC-Unique: SzJzWLRANaeprjDqOBZFyA-1 Received: by mail-qv1-f71.google.com with SMTP id es11so9067193qvb.10 for ; Mon, 02 Nov 2020 13:25:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2Snpjj32EZfd5zmVNHpW7WN3b1s9Tl7X56oVsWAnz9o=; b=Ug94jsOEEyU7gAqzpiRSG+fz9tFwTHNle9ohuHRSzxrmVA8yGKhhmL/3e2fuIjo/vH Hknm6BlB5fQDVXM5goHmCoV6aVV+U56pp6vs7AEiD+wXiYt5BeUwPNmNqx9G+4mzNrxw Kyx1r/W+D2Nr2r0FNrquPpXlq1WrULaigm61/kbEiCChOc5Dxc66OHNhvwYKgi0qiv8B uuF8DD5/cN5FEO8EoKeoB5Z9gXzZOEqyrMbNkzIoU2X0R0PsdVEvipx7nOhe0xk4N8rZ DjcMiBqTxPLIaOBoBXsmgOcPYWM/XA4YFZdhbwn1Y8VqU3NYeK7P4WPtZ4BiFkJ6aTXh +O4Q== X-Gm-Message-State: AOAM532YC/ZZWX0vr2de/dU+rHcebjLfaUBEWArgF+Z+mfV/zVcnwroB y0lWz9LqemxSQ/D6beO0UDezLjsDov1p9KzsXPfNie8B6/+WqScjOQuy5ZOVIDJsB+clBuLl+a8 SthlFi0+Bn2AuPQ6i49pBvs22pPro X-Received: by 2002:a0c:9e65:: with SMTP id z37mr23932533qve.39.1604352304134; Mon, 02 Nov 2020 13:25:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJxkIen1WxObQhiBFilRgn0oiKxkscksHmJoYZSNhTeZY3UShOgAtjQGKu6TtMww+h5CYXJCkg== X-Received: by 2002:a0c:9e65:: with SMTP id z37mr23932523qve.39.1604352303964; Mon, 02 Nov 2020 13:25:03 -0800 (PST) Received: from xz-x1 (bras-vprn-toroon474qw-lp130-20-174-93-89-196.dsl.bell.ca. [174.93.89.196]) by smtp.gmail.com with ESMTPSA id p2sm4590055qkk.34.2020.11.02.13.25.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 13:25:03 -0800 (PST) Date: Mon, 2 Nov 2020 16:25:01 -0500 From: Peter Xu To: Ben Gardon Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Paolo Bonzini , Andrew Jones , Peter Shier , Sean Christopherson , Thomas Huth , Peter Feiner Subject: Re: [PATCH 2/5] KVM: selftests: Remove address rounding in guest code Message-ID: <20201102212501.GC20600@xz-x1> References: <20201027233733.1484855-1-bgardon@google.com> <20201027233733.1484855-3-bgardon@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201027233733.1484855-3-bgardon@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Tue, Oct 27, 2020 at 04:37:30PM -0700, Ben Gardon wrote: > Rounding the address the guest writes to a host page boundary > will only have an effect if the host page size is larger than the guest > page size, but in that case the guest write would still go to the same > host page. There's no reason to round the address down, so remove the > rounding to simplify the demand paging test. > > This series was tested by running the following invocations on an Intel > Skylake machine: > dirty_log_perf_test -b 20m -i 100 -v 64 > dirty_log_perf_test -b 20g -i 5 -v 4 > dirty_log_perf_test -b 4g -i 5 -v 32 > demand_paging_test -b 20m -v 64 > demand_paging_test -b 20g -v 4 > demand_paging_test -b 4g -v 32 > All behaved as expected. > > Signed-off-by: Ben Gardon Nit: would be better to be before the code movement. In all cases: Reviewed-by: Peter Xu -- Peter Xu