From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96B13C2D0A3 for ; Wed, 4 Nov 2020 19:07:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FDBE2080D for ; Wed, 4 Nov 2020 19:07:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="KnWHT2OU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730165AbgKDTHT (ORCPT ); Wed, 4 Nov 2020 14:07:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729784AbgKDTHS (ORCPT ); Wed, 4 Nov 2020 14:07:18 -0500 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96EA6C0613D4 for ; Wed, 4 Nov 2020 11:07:18 -0800 (PST) Received: by mail-pg1-x544.google.com with SMTP id i7so15433625pgh.6 for ; Wed, 04 Nov 2020 11:07:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hjSSC3tt8p/75sU4HCBAJWqPHKqxgfCJ1FmAe9+VYac=; b=KnWHT2OUy4hMo9/BmVfv0xknGutGjNJ1KtmGKB+R/+1gSRWjJNxBtjVAvtVQfzIh5G JDe2tB4aSHDYX5mLG0PLq4KT/1vXTgoaSE1ql5aTgcDsGe+65bK13hzvdJChBMbcfExj sm4VIxu6QtBbMh2Kj2JucY/OIavcb4Bgbis/M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hjSSC3tt8p/75sU4HCBAJWqPHKqxgfCJ1FmAe9+VYac=; b=jXmtJ9174WNv8XwegxbYJJm63d8YKYKAzPzvFt1zKO0gkIDaHNgiGbzEo+OQiCQpW5 isO36vs2/TJEn7X/O6CLbtg3sbHfVNbHvGwvsDB30Hpw9fRLnLC2I0tAvbl+xowFKVW2 0J8Ip9j3nVhXtYncoT4H/yKhZBOkuxDM3QNhA6eUehEZMzXTke4JxvOfOUjTuQ3Y5s5s xNUsTzbrR5BUTnk+HeYhHCHyS25RzpynStroi42GXLwON3ifFp914/zu9AfbVYZOffZx L6x4HatfQGdBjMY6BcuJozy8d0FZi13M9BXAeiLwMNug13qSXF3TtoiEI2rzR2P4NDYv /UZA== X-Gm-Message-State: AOAM530A5ILe7T+OKeF6J7MV2qIe6Ng4bQacJPPfYjn8tqKEn1xvAOAv Xg+yLl+h7RjfLua6Lxgw1WCU6Q== X-Google-Smtp-Source: ABdhPJzIv2cvySmYjFFmSkxxCZUKe/o/tqZdhtwdvmiPabaMXC3F2FzHiw6gBfeyzHAOjN+2/F22eQ== X-Received: by 2002:a65:56cd:: with SMTP id w13mr22554369pgs.132.1604516838025; Wed, 04 Nov 2020 11:07:18 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id w143sm3245488pfc.31.2020.11.04.11.07.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 11:07:17 -0800 (PST) Date: Wed, 4 Nov 2020 11:07:16 -0800 From: Kees Cook To: Michael Ellerman Cc: linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/exec: Fix building of exec test Message-ID: <202011041105.5A2D9D1F@keescook> References: <20201104100706.659089-1-mpe@ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201104100706.659089-1-mpe@ellerman.id.au> Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Wed, Nov 04, 2020 at 09:07:06PM +1100, Michael Ellerman wrote: > Currently the exec test does not build: > > make[1]: Entering directory '/linux/tools/testing/selftests/exec' > ... > make[1]: *** No rule to make target '/output/kselftest/exec/pipe', needed by 'all'. > > This is because pipe is listed in TEST_GEN_FILES, but pipe is not > generated by the Makefile, it's created at runtime. So drop pipe from > TEST_GEN_FILES. Ah, yes, shouldn't it be added to EXTRA_CLEAN though? Fixes: 61016db15b8e ("selftests/exec: Verify execve of non-regular files fail") > > With that fixed, then install fails: > > make[1]: Entering directory '/linux/tools/testing/selftests/exec' > rsync -a binfmt_script non-regular /output/install/exec/ > rsync: link_stat "/linux/tools/testing/selftests/exec/non-regular" failed: No such file or directory (2) > > That's because non-regular hasn't been built, because it's in > TEST_PROGS, it should be part of TEST_GEN_PROGS to indicate that it > needs to be built. Yes, thanks again! Fixes: 0f71241a8e32 ("selftests/exec: add file type errno tests") for both: Acked-by: Kees Cook -- Kees Cook