From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2E78C2D0E4 for ; Tue, 17 Nov 2020 15:52:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81B9C2463D for ; Tue, 17 Nov 2020 15:52:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726575AbgKQPvd (ORCPT ); Tue, 17 Nov 2020 10:51:33 -0500 Received: from mga03.intel.com ([134.134.136.65]:56264 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725767AbgKQPvc (ORCPT ); Tue, 17 Nov 2020 10:51:32 -0500 IronPort-SDR: WNRW3/kM6oZbruqeH4iVTgxPnPlYUWwUfIkXvgPHWF9XYXISo93YJYmxOLxxLPL9zVDcwCIXvb b5OUrUlKUZpQ== X-IronPort-AV: E=McAfee;i="6000,8403,9808"; a="171048493" X-IronPort-AV: E=Sophos;i="5.77,485,1596524400"; d="scan'208";a="171048493" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2020 07:51:19 -0800 IronPort-SDR: Cv3lruze8b3N6ng5La45QtfJkKs8xiHueQMBdK7RWayj8xN443vrPVb3Zo+kYoYJ5SjrDj7mXI y9Sz9Pmcqyaw== X-IronPort-AV: E=Sophos;i="5.77,485,1596524400"; d="scan'208";a="362547403" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2020 07:51:17 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kf3HG-007MJ0-Ub; Tue, 17 Nov 2020 17:52:18 +0200 Date: Tue, 17 Nov 2020 17:52:18 +0200 From: Andy Shevchenko To: David Gow Cc: Andrew Morton , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Shuah Khan , Vitor Massaru Iha , Mark Brown , Brendan Higgins Subject: Re: [PATCH v4 6/6] lib/cmdline_kunit: Add a new test suite for cmdline API Message-ID: <20201117155218.GP4077@smile.fi.intel.com> References: <20201112180732.75589-1-andriy.shevchenko@linux.intel.com> <20201112180732.75589-6-andriy.shevchenko@linux.intel.com> <20201112191025.bd5df6a1f1f6b0419980da1a@linux-foundation.org> <20201116095309.GR4077@smile.fi.intel.com> <20201116104131.GV4077@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Tue, Nov 17, 2020 at 07:43:28AM +0800, David Gow wrote: > On Mon, Nov 16, 2020 at 6:40 PM Andy Shevchenko > wrote: > > > > On Mon, Nov 16, 2020 at 11:53:09AM +0200, Andy Shevchenko wrote: > > > On Thu, Nov 12, 2020 at 07:10:25PM -0800, Andrew Morton wrote: > > > > On Thu, 12 Nov 2020 20:07:32 +0200 Andy Shevchenko wrote: > > > > > > > > > Test get_option() for a starter which is provided by cmdline.c. > > > > > > > > > > ... > > > > > > > > > > lib/cmdline_kunit.c | 98 +++++++++++++++++++++++++++++++++++++++++++++ > > > > > > First of all, thanks for taking care of this! > > > > > > > The spectacular warning storm which this produces makes me wonder if > > > > you sent the correct version? I mean, the cmdline_test_values[] > > > > definition wasn't even close. > > > > > > This now puzzles me, what happened. I will check my branches, because certainly > > > I was not only compiled that, but actually run those test cases. > > > > David, Brendan, can we somehow make those warnings visible when run test suite > > via kunit Python wrapper? > > There's a patch in the kunit-fixes branch which should fix this this: > https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=kunit-fixes&id=390881448b1ff1e9d82896abbbda7cdb8e0be27c Good we have a fix! > > It seems to me that I run test cases only via wrapper and I have got no > > warnings which are ones that must be fixed before submission. It's actual > > disadvantage of the framework (use of it via wrapper) that makes me feel > > like I would rather not hurry up with KUnit. > > Yeah: it's a pain, and I've been hit by it a couple of times recently, > too. If you're not able to pick up the changes in the kunit-fixes > branch above, then it's definitely best to also manually build a > kernel to get the build logs. > > In any case, that fix should be merged for 5.10. > > Sorry for the inconvenience! No problem, I will keep above in mind, thanks. -- With Best Regards, Andy Shevchenko