Re: [PATCH v41 20/24] selftests/x86: Add a selftest for SGX

Shuah Khan
2020-11-16T18:19:37Z

On 11/12/20 3:01 PM, Jarkko Sakkinen wrote:
> Add a selftest for SGX. It is a trivial test where a simple enclave copies
> one 64-bit word of memory between two memory locations, but ensures that
> all SGX hardware and software infrastructure is functioning.
>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: linux-kselftest@vger.kernel.org
> Acked-by: Jethro Beekman <jethro@fortanix.com> # v40
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> ---
> Changes from v40:
> * Remove $(OUTPUT)/test_encl.elf from TEST_CUSTOM_PROGS, as otherwise
> run_tests tries to execute it. Add it as a build dependency.
> * Use the correct device path, /dev/sgx_enclave, instead of
> /dev/sgx/enclave.
> * Return kselftest framework expected return codes.
>
> tools/testing/selftests/Makefile | 1 +
> tools/testing/selftests/sgx/.gitignore | 2 +
> tools/testing/selftests/sgx/Makefile | 53 +++
> tools/testing/selftests/sgx/call.S | 44 ++
> tools/testing/selftests/sgx/defines.h | 21 +
> tools/testing/selftests/sgx/load.c | 277 +++++++++++++
> tools/testing/selftests/sgx/main.c | 246 +++++++++++
> tools/testing/selftests/sgx/main.h | 38 ++
> tools/testing/selftests/sgx/sigstruct.c | 391 ++++++++++++++++++
> tools/testing/selftests/sgx/test_encl.c | 20 +
> tools/testing/selftests/sgx/test_encl.lds | 40 ++
> .../selftests/sgx/test_encl_bootstrap.S | 89 ++++
> 12 files changed, 1222 insertions(+)
> create mode 100644 tools/testing/selftests/sgx/.gitignore
> create mode 100644 tools/testing/selftests/sgx/Makefile
> create mode 100644 tools/testing/selftests/sgx/call.S
> create mode 100644 tools/testing/selftests/sgx/defines.h
> create mode 100644 tools/testing/selftests/sgx/load.c
> create mode 100644 tools/testing/selftests/sgx/main.c
> create mode 100644 tools/testing/selftests/sgx/main.h
> create mode 100644 tools/testing/selftests/sgx/sigstruct.c
> create mode 100644 tools/testing/selftests/sgx/test_encl.c
> create mode 100644 tools/testing/selftests/sgx/test_encl.lds
> create mode 100644 tools/testing/selftests/sgx/test_encl_bootstrap.S
>
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index d9c283503159..aa06e3ea0250 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -68,6 +68,7 @@ TARGETS += user
> TARGETS += vm
> TARGETS += x86
> TARGETS += zram
> +TARGETS += sgx
> #Please keep the TARGETS list alphabetically sorted

Please keep the list sorted alphabetically as stated
in the comment above.

> +}
> +
> +int main(int argc, char *argv[], char *envp[])
> +{
> + struct sgx_enclave_run run;
> + struct vdso_symtab symtab;
> + Elf64_Sym *eenter_sym;
> + uint64_t result = 0;
> + struct encl encl;
> + unsigned int i;
> + void *addr;
> + int ret;
> +
> + memset(&run, 0, sizeof(run));
> +
> + if (!encl_load("test_encl.elf", &encl)) {
> + encl_delete(&encl);
> + ksft_exit_skip("cannot load enclaves\n");
> + }
> +
> + if (!encl_measure(&encl))
> + goto err;
> +
> + if (!encl_build(&encl))
> + goto err;
> +
> + /*
> + * An enclave consumer only must do this.
> + */
> + for (i = 0; i < encl.nr_segments; i++) {
> + struct encl_segment *seg = &encl.segment_tbl[i];
> +
> + addr = mmap((void *)encl.encl_base + seg->offset, seg->size,
> + seg->prot, MAP_SHARED | MAP_FIXED, encl.fd, 0);
> + if (addr == MAP_FAILED) {
> + fprintf(stderr, "mmap() failed, errno=%d.\n", errno);
> + exit(1);

This should be KSFT_FAIL.

thanks,
-- Shuah