Re: [PATCH] selftests/x86: Fix malformed src_offset initialization

Jarkko Sakkinen
2020-11-18T17:59:19Z

On Wed, Nov 18, 2020 at 06:19:00PM +0100, Borislav Petkov wrote:
> On Wed, Nov 18, 2020 at 12:36:30AM +0200, Jarkko Sakkinen wrote:
> > Assign src_offset just to the p_offset, when first initialized.
> > This has been probably copy-pasting accident (at least looks like
> > it).
> >
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Shuah Khan <shuah@kernel.org>
> > Cc: linux-kselftest@vger.kernel.org
> > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> > ---
> > tools/testing/selftests/sgx/load.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/sgx/load.c b/tools/testing/selftests/sgx/load.c
> > index 07988de6b767..64976f266bae 100644
> > --- a/tools/testing/selftests/sgx/load.c
> > +++ b/tools/testing/selftests/sgx/load.c
> > @@ -185,7 +185,7 @@ bool encl_load(const char *path, struct encl *encl)
> > }
> >
> > if (j == 0) {
> > - src_offset = (phdr->p_offset & PAGE_MASK) - src_offset;
> > + src_offset = (phdr->p_offset & PAGE_MASK);
> >
> > seg->prot = PROT_READ | PROT_WRITE;
> > seg->flags = SGX_PAGE_TYPE_TCS << 8;
> > --
>
> Folded in after removing the brackets and pushed the whole thing out.
> Phew, finally!
>
> From now on, only fixes ontop pls and testing tip:x86/sgx would be of
> great help.
>
> Thx.

Duh, I sent the fix for the selftest before seeing this.

Thank you, I'll separately clone tip and test it.

> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette

/Jarkko