Re: [PATCH] selftests/harness: pass variant to teardown

[Kees Cook <keescook@chromium.org>]

Hi Shuah,

Any news on these? I'd like to see them.

-Kees

On Fri, Feb 05, 2021 at 10:11:52PM -0500, Willem de Bruijn wrote:
> On Fri, Dec 11, 2020 at 1:15 PM Kees Cook <keescook@chromium.org> wrote:
> >
> > On Thu, Dec 10, 2020 at 06:10:10PM -0500, Willem de Bruijn wrote:
> > > From: Willem de Bruijn <willemb@google.com>
> > >
> > > FIXTURE_VARIANT data is passed to FIXTURE_SETUP and TEST_F as variant.
> > >
> > > In some cases, the variant will change the setup, such that expections
> > > also change on teardown. Also pass variant to FIXTURE_TEARDOWN.
> > >
> > > The new FIXTURE_TEARDOWN logic is identical to that in FIXTURE_SETUP,
> > > right above.
> > >
> > > Signed-off-by: Willem de Bruijn <willemb@google.com>
> >
> > Thanks! This was on my TODO list. :)
> >
> > Acked-by: Kees Cook <keescook@chromium.org>
> 
> Is this patch staged to be merged as is? Should I resubmit it?
> 
> Same question for another slightly older (2020-11-23) kselftest patch:
> 
>     tools/testing: add kselftest shell helper library
>     https://patchwork.kernel.org/project/linux-kselftest/patch/20201123162508.585279-1-willemdebruijn.kernel@gmail.com/
> 
> Thanks,
> 
>   Willem

-- 
Kees Cook