Re: [PATCH v4 2/2] kunit: tool: allow filtering test cases via glob

kernel test robot
2021-09-10T01:50:03Z

[-- Attachment #1: Type: text/plain, Size: 1977 bytes --]

Hi Daniel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on a3fa7a101dcff93791d1b1bdb3affcad1410c8c1]

url: https://github.com/0day-ci/linux/commits/Daniel-Latypov/kunit-drop-assumption-in-kunit-log-test-about-current-suite/20210910-011213
base: a3fa7a101dcff93791d1b1bdb3affcad1410c8c1
config: riscv-randconfig-s032-20210910 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/3d5c1af613421e9022fdf3523933c7c5fa3f7357
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Daniel-Latypov/kunit-drop-assumption-in-kunit-log-test-about-current-suite/20210910-011213
git checkout 3d5c1af613421e9022fdf3523933c7c5fa3f7357
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=riscv SHELL=/bin/bash lib/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
lib/kunit/executor.c: note: in included file:
>> lib/kunit/executor_test.c:20:19: sparse: sparse: symbol 'dummy_test_cases' was not declared. Should it be static?

vim +/dummy_test_cases +20 lib/kunit/executor_test.c

19
> 20 struct kunit_case dummy_test_cases[] = {
21 /* .run_case is not important, just needs to be non-NULL */
22 { .name = "test1", .run_case = dummy_test },
23 { .name = "test2", .run_case = dummy_test },
24 {},
25 };
26

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32329 bytes --]