From: Kalesh Singh <kaleshsingh@google.com>
To: unlisted-recipients:; (no To-header on input)
Cc: surenb@google.com, hridya@google.com, namhyung@kernel.org,
kernel-team@android.com, rostedt@goodmis.org,
mhiramat@kernel.org, Kalesh Singh <kaleshsingh@google.com>,
Ingo Molnar <mingo@redhat.com>, Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: [PATCH 2/3] tracing/kselftests: Remove triggers with references before their definitions
Date: Wed, 27 Oct 2021 13:59:09 -0700 [thread overview]
Message-ID: <20211027205919.1648553-3-kaleshsingh@google.com> (raw)
In-Reply-To: <20211027205919.1648553-1-kaleshsingh@google.com>
If an event trigger references a variable defined in another trigger, it
has to be removed before the trigger that defines the variable is
removed.
Signed-off-by: Kalesh Singh <kaleshsingh@google.com>
---
tools/testing/selftests/ftrace/test.d/functions | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/tools/testing/selftests/ftrace/test.d/functions b/tools/testing/selftests/ftrace/test.d/functions
index 000fd05e84b1..bd9e85f4d626 100644
--- a/tools/testing/selftests/ftrace/test.d/functions
+++ b/tools/testing/selftests/ftrace/test.d/functions
@@ -22,6 +22,15 @@ reset_trigger_file() {
file=`echo $line | cut -f1 -d:`
echo "!$cmd" >> $file
done
+
+ # remove triggers with references next
+ grep -H '\$' $@ |
+ while read line; do
+ cmd=`echo $line | cut -f2- -d: | cut -f1 -d"["`
+ file=`echo $line | cut -f1 -d:`
+ echo "!$cmd" >> $file
+ done
+
grep -Hv ^# $@ |
while read line; do
cmd=`echo $line | cut -f2- -d: | cut -f1 -d"["`
--
2.33.0.1079.g6e70778dc9-goog
next prev parent reply other threads:[~2021-10-27 21:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 20:59 [PATCH 0/3] tracing/kselftest: histogram trigger expression tests Kalesh Singh
2021-10-27 20:59 ` [PATCH 1/3] tracing/histogram: Document hist trigger variables Kalesh Singh
2021-10-27 22:13 ` Masami Hiramatsu
2021-10-27 20:59 ` Kalesh Singh [this message]
2021-10-27 21:58 ` [PATCH 2/3] tracing/kselftests: Remove triggers with references before their definitions Masami Hiramatsu
2021-10-27 23:26 ` Kalesh Singh
2021-10-27 23:54 ` Steven Rostedt
2021-10-28 0:43 ` Masami Hiramatsu
2021-10-28 2:58 ` Kalesh Singh
2021-10-28 17:10 ` Kalesh Singh
2021-10-27 20:59 ` [PATCH v5 3/3] tracing/selftests: Add tests for hist trigger expression parsing Kalesh Singh
2021-10-27 22:12 ` Masami Hiramatsu
2021-10-27 21:04 ` [PATCH 0/3] tracing/kselftest: histogram trigger expression tests Kalesh Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211027205919.1648553-3-kaleshsingh@google.com \
--to=kaleshsingh@google.com \
--cc=hridya@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox