From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28056C433EF for ; Tue, 8 Mar 2022 07:20:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236167AbiCHHVD (ORCPT ); Tue, 8 Mar 2022 02:21:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232229AbiCHHVD (ORCPT ); Tue, 8 Mar 2022 02:21:03 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF36A33A01 for ; Mon, 7 Mar 2022 23:20:07 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 05D0C68AFE; Tue, 8 Mar 2022 08:20:03 +0100 (CET) Date: Tue, 8 Mar 2022 08:20:02 +0100 From: Christoph Hellwig To: Tian Tao Cc: song.bao.hua@hisilicon.com, hch@lst.de, shuah@kernel.org, chenxiang66@hisilicon.com, skhan@linuxfoundation.org, iommu@lists.linux-foundation.org, linux-kselftest@vger.kernel.org, linuxarm@openeuler.org Subject: Re: [RESEND] dma-mapping: benchmark: Extract a common header file for map_benchmark definition Message-ID: <20220308072002.GA24887@lst.de> References: <20220308062857.45585-1-tiantao6@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220308062857.45585-1-tiantao6@hisilicon.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Tue, Mar 08, 2022 at 02:28:57PM +0800, Tian Tao wrote: > kernel/dma/map_benchmark.c and selftests/dma/dma_map_benchmark.c > have duplicate map_benchmark definitions, which tends to lead to > inconsistent changes to map_benchmark on both sides, extract a > common header file to avoid this problem. > > Signed-off-by: Tian Tao > Acked-by: Barry Song > Reviewed-by: Shuah Khan > --- > kernel/dma/map_benchmark.c | 24 +------------- > kernel/dma/map_benchmark.h | 31 +++++++++++++++++++ > .../testing/selftests/dma/dma_map_benchmark.c | 25 +-------------- This needs to go into include/uapi/ instead of using unmaintainable local includes that poke into other directories.