From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org,
Florian Westphal <fw@strlen.de>
Subject: [PATCH nf 0/2] testing: selftests: nft_flowtable.sh: unbreak test script
Date: Tue, 16 Aug 2022 14:15:20 +0200 [thread overview]
Message-ID: <20220816121522.14278-1-fw@strlen.de> (raw)
nft_flowtable.sh fails most of the time since
2738d9d963bd1f0 ("netfilter: flowtable: move dst_check to packet path").
Arguably the test scripts way of detecting 'offloaded' vs 'offload
failed' was always flaky/broken.
These patches fix this up:
1. first patch moves to random netns names so we don't trip
over existing 'ns1' name (too generic...).
2. second patch reworks the 'offload appears to be non-working'
by means of packet counters.
Because counters are only incremented when a packet is handled
by the classic forward path, check that the counter is lower than
a given threshold (25% of file size).
Florian Westphal (2):
testing: selftests: nft_flowtable.sh: use random netns names
testing: selftests: nft_flowtable.sh: rework test to detect offload
failure
.../selftests/netfilter/nft_flowtable.sh | 377 ++++++++++--------
1 file changed, 207 insertions(+), 170 deletions(-)
--
2.35.1
next reply other threads:[~2022-08-16 12:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 12:15 Florian Westphal [this message]
2022-08-16 12:15 ` [PATCH nf 1/2] testing: selftests: nft_flowtable.sh: use random netns names Florian Westphal
2022-08-16 12:15 ` [PATCH nf 2/2] testing: selftests: nft_flowtable.sh: rework test to detect offload failure Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220816121522.14278-1-fw@strlen.de \
--to=fw@strlen.de \
--cc=linux-kselftest@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox