From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE888C38A2D for ; Tue, 25 Oct 2022 12:42:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232042AbiJYMmr (ORCPT ); Tue, 25 Oct 2022 08:42:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232073AbiJYMmh (ORCPT ); Tue, 25 Oct 2022 08:42:37 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 758E318BE37 for ; Tue, 25 Oct 2022 05:42:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666701754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YKqk8JFJPFyZT4uxuIdJDMrDXX3QslvogL56oEpKGVE=; b=HyxUij/zbzb4wx7sOhSthGAR1kigJ7mUPXjB7QeFjbJw9Ig0tNz0XwDGv8KFe7dwCXjzM5 dlFeSownJuRTPHEcx2vNxYQeFjhFcVf7gmlQtWv7RAO0MRDosrcx4u/GztJyzDOh0pZMZN N3IMwMTmJtZFiqTM/H62Ulz5FmXPjVs= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-341-73h3obR2O_m7aheX040YGA-1; Tue, 25 Oct 2022 08:42:30 -0400 X-MC-Unique: 73h3obR2O_m7aheX040YGA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E26DC3C0D84F; Tue, 25 Oct 2022 12:42:27 +0000 (UTC) Received: from amdlaptop.tlv.redhat.com (dhcp-4-238.tlv.redhat.com [10.35.4.238]) by smtp.corp.redhat.com (Postfix) with ESMTP id 428352024CCA; Tue, 25 Oct 2022 12:42:24 +0000 (UTC) From: Maxim Levitsky To: kvm@vger.kernel.org Cc: Paolo Bonzini , Yang Zhong , linux-kselftest@vger.kernel.org, Kees Cook , Borislav Petkov , Guang Zeng , Wanpeng Li , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Maxim Levitsky , Joerg Roedel , linux-kernel@vger.kernel.org, Wei Wang , Jim Mattson , Dave Hansen , Sean Christopherson , Vitaly Kuznetsov , x86@kernel.org, Shuah Khan Subject: [PATCH v4 00/23] SMM emulation and interrupt shadow fixes Date: Tue, 25 Oct 2022 15:42:00 +0300 Message-Id: <20221025124223.227577-1-mlevitsk@redhat.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org This patch series is a result of long debug work to find out why=0D sometimes guests with win11 secure boot=0D were failing during boot.=0D =0D During writing a unit test I found another bug, turns out=0D that on rsm emulation, if the rsm instruction was done in real=0D or 32 bit mode, KVM would truncate the restored RIP to 32 bit.=0D =0D I also refactored the way we write SMRAM so it is easier=0D now to understand what is going on.=0D =0D The main bug in this series which I fixed is that we=0D allowed #SMI to happen during the STI interrupt shadow,=0D and we did nothing to both reset it on #SMI handler=0D entry and restore it on RSM.=0D =0D V4:=0D =0D - rebased on top of patch series from Paolo which=0D allows smm support to be disabled by Kconfig option.=0D =0D - addressed review feedback.=0D =0D I included these patches in the series for reference.=0D =0D Best regards,=0D Maxim Levitsky=0D =0D Maxim Levitsky (15):=0D bug: introduce ASSERT_STRUCT_OFFSET=0D KVM: x86: emulator: em_sysexit should update ctxt->mode=0D KVM: x86: emulator: introduce emulator_recalc_and_set_mode=0D KVM: x86: emulator: update the emulation mode after rsm=0D KVM: x86: emulator: update the emulation mode after CR0 write=0D KVM: x86: smm: number of GPRs in the SMRAM image depends on the image=0D format=0D KVM: x86: smm: check for failures on smm entry=0D KVM: x86: smm: add structs for KVM's smram layout=0D KVM: x86: smm: use smram structs in the common code=0D KVM: x86: smm: use smram struct for 32 bit smram load/restore=0D KVM: x86: smm: use smram struct for 64 bit smram load/restore=0D KVM: svm: drop explicit return value of kvm_vcpu_map=0D KVM: x86: SVM: use smram structs=0D KVM: x86: SVM: don't save SVM state to SMRAM when VM is not long mode=0D capable=0D KVM: x86: smm: preserve interrupt shadow in SMRAM=0D =0D Paolo Bonzini (8):=0D KVM: x86: start moving SMM-related functions to new files=0D KVM: x86: move SMM entry to a new file=0D KVM: x86: move SMM exit to a new file=0D KVM: x86: do not go through ctxt->ops when emulating rsm=0D KVM: allow compiling out SMM support=0D KVM: x86: compile out vendor-specific code if SMM is disabled=0D KVM: x86: remove SMRAM address space if SMM is not supported=0D KVM: x86: do not define KVM_REQ_SMI if SMM disabled=0D =0D arch/x86/include/asm/kvm-x86-ops.h | 2 +=0D arch/x86/include/asm/kvm_host.h | 29 +-=0D arch/x86/kvm/Kconfig | 11 +=0D arch/x86/kvm/Makefile | 1 +=0D arch/x86/kvm/emulate.c | 458 +++----------=0D arch/x86/kvm/kvm_cache_regs.h | 5 -=0D arch/x86/kvm/kvm_emulate.h | 47 +-=0D arch/x86/kvm/lapic.c | 14 +-=0D arch/x86/kvm/lapic.h | 7 +-=0D arch/x86/kvm/mmu/mmu.c | 1 +=0D arch/x86/kvm/smm.c | 637 ++++++++++++++++++=0D arch/x86/kvm/smm.h | 160 +++++=0D arch/x86/kvm/svm/nested.c | 3 +=0D arch/x86/kvm/svm/svm.c | 43 +-=0D arch/x86/kvm/vmx/nested.c | 1 +=0D arch/x86/kvm/vmx/vmcs12.h | 5 +-=0D arch/x86/kvm/vmx/vmx.c | 11 +-=0D arch/x86/kvm/x86.c | 353 +---------=0D include/linux/build_bug.h | 9 +=0D tools/testing/selftests/kvm/x86_64/smm_test.c | 2 +=0D 20 files changed, 1031 insertions(+), 768 deletions(-)=0D create mode 100644 arch/x86/kvm/smm.c=0D create mode 100644 arch/x86/kvm/smm.h=0D =0D -- =0D 2.34.3=0D =0D