From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87D7EC4332F for ; Fri, 4 Nov 2022 01:16:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229983AbiKDBQO (ORCPT ); Thu, 3 Nov 2022 21:16:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229699AbiKDBQN (ORCPT ); Thu, 3 Nov 2022 21:16:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FAC719039; Thu, 3 Nov 2022 18:16:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 18CE661FB8; Fri, 4 Nov 2022 01:16:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF727C433D7; Fri, 4 Nov 2022 01:16:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667524571; bh=YxLmpDgWn8gCU1i4xVPVk/YA8YZRM+FhFvMSOiVbJDM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=g8fWz5skh/NDEC8GhhKp62jCO6kgIAI2NgMghcXl3aumAYUrtnWjsBKWuMiSz6xGc J0RRm9kB6S4e28TZUxPg7DafaQ10yUdVQ6BwlfCKlApPqKuhNgvUDOQZaIcWKakiZE wYyyjvuMSQGNpvhZtR5OYr2W2M5CPT69t9cJQvMzIgFmVSHvocYqG7JBWU7E//h1A9 OwEtw9j0jzH1Jc9BzaIU6HIANVgT+mUD+413A6fzW0dojzqKDJ7hSxEtd+dBq1NHlL OB91WEJ3dqzz0n74j93h23q82iaOIofyaeuRObbPdbTD8RwjgVIhuY+qHjKCpVbG7S 9PhPdalCm4fUg== Date: Fri, 4 Nov 2022 10:16:07 +0900 From: Masami Hiramatsu (Google) To: "Naveen N. Rao" Cc: Shuah Khan , Steven Rostedt , , , Masami Hiramatsu , Akanksha J N Subject: Re: [RESEND PATCH v2 2/2] selftests/ftrace: Convert tracer tests to use 'requires' to specify program dependency Message-Id: <20221104101607.844382ef3dc5e2515febaa21@kernel.org> In-Reply-To: References: X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Fri, 28 Oct 2022 12:46:10 +0530 "Naveen N. Rao" wrote: > Now that we have a good way to specify dependency of tests on programs, > convert some of the tracer tests to use this method for specifying > dependency on 'chrt'. > Looks good to me. Acked-by: Masami Hiramatsu (Google) Thanks! > Reviewed-by: Steven Rostedt (Google) > Signed-off-by: Naveen N. Rao > --- > tools/testing/selftests/ftrace/test.d/tracer/wakeup.tc | 7 +------ > tools/testing/selftests/ftrace/test.d/tracer/wakeup_rt.tc | 7 +------ > 2 files changed, 2 insertions(+), 12 deletions(-) > > diff --git a/tools/testing/selftests/ftrace/test.d/tracer/wakeup.tc b/tools/testing/selftests/ftrace/test.d/tracer/wakeup.tc > index 11be10e1bf966a..e8f0fac9a110cc 100644 > --- a/tools/testing/selftests/ftrace/test.d/tracer/wakeup.tc > +++ b/tools/testing/selftests/ftrace/test.d/tracer/wakeup.tc > @@ -1,12 +1,7 @@ > #!/bin/sh > # SPDX-License-Identifier: GPL-2.0 > # description: Test wakeup tracer > -# requires: wakeup:tracer > - > -if ! which chrt ; then > - echo "chrt is not found. This test requires nice command." > - exit_unresolved > -fi > +# requires: wakeup:tracer chrt:program > > echo wakeup > current_tracer > echo 1 > tracing_on > diff --git a/tools/testing/selftests/ftrace/test.d/tracer/wakeup_rt.tc b/tools/testing/selftests/ftrace/test.d/tracer/wakeup_rt.tc > index 3a77198b3c6902..79807656785b0f 100644 > --- a/tools/testing/selftests/ftrace/test.d/tracer/wakeup_rt.tc > +++ b/tools/testing/selftests/ftrace/test.d/tracer/wakeup_rt.tc > @@ -1,12 +1,7 @@ > #!/bin/sh > # SPDX-License-Identifier: GPL-2.0 > # description: Test wakeup RT tracer > -# requires: wakeup_rt:tracer > - > -if ! which chrt ; then > - echo "chrt is not found. This test requires chrt command." > - exit_unresolved > -fi > +# requires: wakeup_rt:tracer chrt:program > > echo wakeup_rt > current_tracer > echo 1 > tracing_on > -- > 2.38.0 > -- Masami Hiramatsu (Google)