From: Steffen Klassert <steffen.klassert@secunet.com>
To: Martin KaFai Lau <martin.lau@linux.dev>
Cc: Eyal Birger <eyal.birger@gmail.com>, <netdev@vger.kernel.org>,
<bpf@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <herbert@gondor.apana.org.au>,
<andrii@kernel.org>, <daniel@iogearbox.net>,
<nicolas.dichtel@6wind.com>, <razor@blackwall.org>,
<mykolal@fb.com>, <ast@kernel.org>, <song@kernel.org>,
<yhs@fb.com>, <john.fastabend@gmail.com>, <kpsingh@kernel.org>,
<sdf@google.com>, <haoluo@google.com>, <jolsa@kernel.org>,
<shuah@kernel.org>
Subject: Re: [PATCH ipsec-next 2/3] xfrm: interface: Add unstable helpers for setting/getting XFRM metadata from TC-BPF
Date: Tue, 29 Nov 2022 10:50:01 +0100 [thread overview]
Message-ID: <20221129095001.GV704954@gauss3.secunet.de> (raw)
In-Reply-To: <c8a2d940-ff85-c952-74d0-25ad2c33c1af@linux.dev>
On Mon, Nov 28, 2022 at 05:58:23PM -0800, Martin KaFai Lau wrote:
> On 11/28/22 8:05 AM, Eyal Birger wrote:
> > This change adds xfrm metadata helpers using the unstable kfunc call
> > interface for the TC-BPF hooks. This allows steering traffic towards
> > different IPsec connections based on logic implemented in bpf programs.
> >
> > This object is built based on the availabilty of BTF debug info.
> >
> > The metadata percpu dsts used on TX take ownership of the original skb
> > dsts so that they may be used as part of the xfrm transmittion logic -
> > e.g. for MTU calculations.
>
> A few quick comments and questions:
>
> >
> > Signed-off-by: Eyal Birger <eyal.birger@gmail.com>
> > ---
> > include/net/dst_metadata.h | 1 +
> > include/net/xfrm.h | 20 ++++++++
> > net/core/dst.c | 4 ++
> > net/xfrm/Makefile | 6 +++
> > net/xfrm/xfrm_interface_bpf.c | 92 ++++++++++++++++++++++++++++++++++
>
> Please tag for bpf-next
This is a change to xfrm ipsec, so it should go
through the ipsec-next tree, unless there is
a good reason for handling that different.
next prev parent reply other threads:[~2022-11-29 9:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 16:04 [PATCH ipsec-next 0/3] xfrm: interface: Add unstable helpers for XFRM metadata Eyal Birger
2022-11-28 16:04 ` [PATCH ipsec-next 1/3] xfrm: interface: rename xfrm_interface.c to xfrm_interface_core.c Eyal Birger
2022-11-28 16:05 ` [PATCH ipsec-next 2/3] xfrm: interface: Add unstable helpers for setting/getting XFRM metadata from TC-BPF Eyal Birger
2022-11-29 1:58 ` Martin KaFai Lau
2022-11-29 8:36 ` Eyal Birger
2022-11-29 9:50 ` Steffen Klassert [this message]
2022-11-29 16:15 ` Jakub Kicinski
2022-11-30 8:39 ` Steffen Klassert
2022-11-30 19:10 ` Martin KaFai Lau
2022-12-01 7:12 ` Steffen Klassert
2022-11-28 16:05 ` [PATCH ipsec-next 3/3] selftests/bpf: add xfrm_info tests Eyal Birger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221129095001.GV704954@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eyal.birger@gmail.com \
--cc=haoluo@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox