From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Mark Brown <broonie@kernel.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, kvm@vger.kernel.org,
Ricardo Koller <ricarkol@google.com>,
Marc Zyngier <maz@kernel.org>,
David Matlack <dmatlack@google.com>,
Sean Christopherson <seanjc@google.com>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] KVM: selftests: Fix build for memstress.[ch] rename
Date: Wed, 7 Dec 2022 07:42:16 +1100 [thread overview]
Message-ID: <20221207074108.42477c2d@canb.auug.org.au> (raw)
In-Reply-To: <20221206175916.250104-1-broonie@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1749 bytes --]
Hi Mark,
On Tue, 6 Dec 2022 17:59:16 +0000 Mark Brown <broonie@kernel.org> wrote:
>
> Today's -next fails to build the KVM selftests on at least arm64 due to
> commit
>
> 9fda6753c9dd ("KVM: selftests: Rename perf_test_util.[ch] to memstress.[ch]")
>
> interacting poorly with commit
>
> a93871d0ea9f ("KVM: selftests: Add a userfaultfd library")
>
> which adds a new user of perf_test_util.h. Do the rename in the new
> user.
>
> Fixes: 9fda6753c9dd ("KVM: selftests: Rename perf_test_util.[ch] to memstress.[ch]")
> Fixes: a93871d0ea9f ("KVM: selftests: Add a userfaultfd library")
> Signed-off-by: Mark Brown <broonie@kernel.org>
> Cc: Ricardo Koller <ricarkol@google.com>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: David Matlack <dmatlack@google.com>
> Cc: Sean Christopherson <seanjc@google.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> tools/testing/selftests/kvm/lib/userfaultfd_util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kvm/lib/userfaultfd_util.c b/tools/testing/selftests/kvm/lib/userfaultfd_util.c
> index 3b44846fc277..92cef20902f1 100644
> --- a/tools/testing/selftests/kvm/lib/userfaultfd_util.c
> +++ b/tools/testing/selftests/kvm/lib/userfaultfd_util.c
> @@ -20,7 +20,7 @@
>
> #include "kvm_util.h"
> #include "test_util.h"
> -#include "perf_test_util.h"
> +#include "memstress.h"
> #include "userfaultfd_util.h"
>
> #ifdef __NR_userfaultfd
> --
> 2.30.2
>
Thanks for that. I have added that as a merge fix patch to the kvm-arm
merge. I assume this will be fixed up when that tree is merged into
the kvm tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-12-06 20:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 17:59 [PATCH] KVM: selftests: Fix build for memstress.[ch] rename Mark Brown
2022-12-06 20:42 ` Stephen Rothwell [this message]
2022-12-07 0:33 ` Paolo Bonzini
2022-12-07 1:44 ` Sean Christopherson
2022-12-07 7:54 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221207074108.42477c2d@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=broonie@kernel.org \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=ricarkol@google.com \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox