From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73858C4332F for ; Thu, 22 Dec 2022 17:45:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229763AbiLVRpr (ORCPT ); Thu, 22 Dec 2022 12:45:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229639AbiLVRpq (ORCPT ); Thu, 22 Dec 2022 12:45:46 -0500 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79A65310 for ; Thu, 22 Dec 2022 09:45:42 -0800 (PST) Received: by mail-pj1-x1030.google.com with SMTP id u15-20020a17090a3fcf00b002191825cf02so2606477pjm.2 for ; Thu, 22 Dec 2022 09:45:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=0sze1nGreiAXsTywGDPG70IW4R2b83boMaSQmXNC/vE=; b=i1UUDCYNa993+xaGBjfg/9QfwtkWdRmcSoJRlKzDgqF9Rha4/nnkfkKA/zpGHmNqbG HaXwo9fbMf2knV8j5gQtR49wtmQfajX6LYcmmUdGfpcYF78TexfpGlZIMFVnPu0KlU1V G4qvDNg3dzSEbUGr1LjKOBhkCU9MBFgk7zRbZc/NU5hUafDmaB0Bj9zYQIEopSGEU/4h XjK6w8iPef1Pse6CTBSj5WgRz498R6rpQpFysqVsRZHQSA/d1BcmFJL5rApQ0XrPGRbD sO8evz8sa9Oa+uI2ChsTql7Zb0HTwUuoPOoZuynHjA4QzGO/Z59UZPXD9l4De9FuaD4i g1oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0sze1nGreiAXsTywGDPG70IW4R2b83boMaSQmXNC/vE=; b=DV0a8Uwk3nidlYytnRJZElQk+K8KUWA1KsDrCKILLg7pPSzuDb4j4KwuQmZXgybC78 CWIvDHK1XmvInKxDMqn7sPLM6qDVbXZKyuKFLA7lolNSE4aj4qDWJ5DAe/jek0LtoMMG ulYSnkIPJDIl0RbLBThKtZtmabZ7yVo4uZUv3P9VpgaCBlKUS4ha1lvUJMGiFW57CNdx PezIwuBwcEG/YoRrugioqY4BTr78d7cYXxdFjZKj+8AZUeP9OUEaaC+kDKZ8l+3JBxyy fu22LGMD2YgR1LwQQzj9N+CvXncs0K4XLpYkpec56OkZ/Dz4GTdUmRMUk1EUZfUQUWYX /a3A== X-Gm-Message-State: AFqh2kqG//9ZIpiRbeVL3FJEZOSWYhZmFZs5Dlc54xrJ2+iJ7rKXYY1j 6EwUCvyfF9n4WfGdRgGSwgVV X-Google-Smtp-Source: AMrXdXt51bcZrZbcp7TU3euTB/meFVmLtdr0W5ttIGWdBxJS04MNVOb1fR1o9I4kVD5im3QkLli5lA== X-Received: by 2002:a17:90b:35c6:b0:219:5b39:9120 with SMTP id nb6-20020a17090b35c600b002195b399120mr7210829pjb.41.1671731141990; Thu, 22 Dec 2022 09:45:41 -0800 (PST) Received: from thinkpad ([117.217.177.177]) by smtp.gmail.com with ESMTPSA id i10-20020a17090a65ca00b00218cd71781csm859075pjs.51.2022.12.22.09.45.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Dec 2022 09:45:40 -0800 (PST) Date: Thu, 22 Dec 2022 23:15:32 +0530 From: Manivannan Sadhasivam To: Shuah Khan Cc: Aman Gupta , shradha.t@samsung.com, pankaj.dubey@samsung.com, kishon@ti.com, lpieralisi@kernel.org, kw@linux.com, shuah@kernel.org, Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org, Padmanabhan Rajanbabu Subject: Re: [PATCH] selftests: pci: pci-selftest: add support for PCI endpoint driver test Message-ID: <20221222174532.GA59500@thinkpad> References: <20221007053934.5188-1-aman1.gupta@samsung.com> <641d1e50-a9d0-dc15-be76-07b8ace25dae@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <641d1e50-a9d0-dc15-be76-07b8ace25dae@linuxfoundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Thu, Dec 22, 2022 at 09:58:30AM -0700, Shuah Khan wrote: > On 10/6/22 23:39, Aman Gupta wrote: > > This patch enables the support to perform selftest on PCIe endpoint > > driver present in the system. The following tests are currently > > performed by the selftest utility > > > > 1. BAR Tests (BAR0 to BAR5) > > 2. MSI Interrupt Tests (MSI1 to MSI32) > > 3. Read Tests (For 1, 1024, 1025, 1024000, 1024001 Bytes) > > 4. Write Tests (For 1, 1024, 1025, 1024000, 1024001 Bytes) > > 5. Copy Tests (For 1, 1024, 1025, 1024000, 1024001 Bytes) > > > > Signed-off-by: Aman Gupta > > Signed-off-by: Padmanabhan Rajanbabu > > Adding Bjorn Helgaas to the thread. > > Adding pcit test under selftests is good. There is another pcitest > under tools/pci. I would like to see if the existing code in > tools/pci/pcitest.c can be leveraged. > > As part of this test work, also look into removing tools/pci so > we don't have to maintain duplicate code in two places. > It has been agreed in a thread with Greg [1] to {re}move the tests under tools/pci and utilize the kselftest. Thanks, Mani [1] https://lore.kernel.org/lkml/Y2FTWLw0tKuZ9Cdl@kroah.com/ > thanks, > -- Shuah -- மணிவண்ணன் சதாசிவம்