Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: benjamin@sipsolutions.net
To: linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com
Cc: Johannes Berg <johannes@sipsolutions.net>,
	Benjamin Berg <benjamin.berg@intel.com>
Subject: [PATCH 3/3] kunit: add a convenience allocation wrapper for SKBs
Date: Wed, 29 Mar 2023 19:23:11 +0200	[thread overview]
Message-ID: <20230329172311.71861-3-benjamin@sipsolutions.net> (raw)
In-Reply-To: <20230329172311.71861-1-benjamin@sipsolutions.net>

From: Benjamin Berg <benjamin.berg@intel.com>

This simplifies the use of SKBs in tests by avoiding the need for
error checking.

Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
---
 include/kunit/skbuff.h | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 include/kunit/skbuff.h

diff --git a/include/kunit/skbuff.h b/include/kunit/skbuff.h
new file mode 100644
index 000000000000..46dcb00af655
--- /dev/null
+++ b/include/kunit/skbuff.h
@@ -0,0 +1,38 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * KUnit struct sk_buff helpers.
+ *
+ * Copyright (C) 2023 Intel Corporation
+ */
+
+#ifndef _KUNIT_SKBUFF_H
+#define _KUNIT_SKBUFF_H
+
+#include <kunit/test.h>
+#include <linux/skbuff.h>
+
+/**
+ * kunit_zalloc_skb() - Allocate and initialize a resource managed skb.
+ * @test: The test case to which the skb belongs
+ * @len: size to allocate
+ * @gfp: allocation mask
+ *
+ * Allocate a new struct sk_buff, zero fill the give length and add it as a
+ * resource to the kunit test for automatic cleanup.
+ *
+ * The function will not return in case of an allocation error.
+ */
+static inline struct sk_buff *kunit_zalloc_skb(struct kunit *test, int len,
+					       gfp_t gfp)
+{
+	struct sk_buff *res = alloc_skb(len, gfp);
+
+	KUNIT_ASSERT_NOT_NULL(test, res);
+	KUNIT_ASSERT_EQ(test, skb_pad(res, len), 0);
+
+	kunit_add_cleanup(test, (kunit_cleanup_t) kfree_skb, res, gfp);
+
+	return res;
+}
+
+#endif /* _KUNIT_SKBUFF_H */
-- 
2.39.2


      parent reply	other threads:[~2023-03-29 17:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29 17:23 [PATCH 1/3] kunit: add parameter generation macro using description from array benjamin
2023-03-29 17:23 ` [PATCH 2/3] kunit: add ability to register a simple cleanup function benjamin
2023-03-30  6:17   ` David Gow
2023-03-30  7:14     ` Benjamin Berg
2023-04-11 15:28   ` kernel test robot
2023-03-29 17:23 ` benjamin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230329172311.71861-3-benjamin@sipsolutions.net \
    --to=benjamin@sipsolutions.net \
    --cc=benjamin.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox