From: Yang Yang <yang.yang29@zte.com.cn>
To: willemdebruijn.kernel@gmail.com
Cc: davem@davemloft.net, edumazet@google.com,
jiang.xuexin@zte.com.cn, kuba@kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com, shuah@kernel.org,
xu.xin16@zte.com.cn, yang.yang29@zte.com.cn,
zhang.yunkai@zte.com.cn
Subject: RE: [PATCH linux-next 1/3] selftests: net: udpgso_bench_rx: Fix verifty exceptions
Date: Tue, 18 Apr 2023 09:29:10 +0800 [thread overview]
Message-ID: <20230418012910.194745-1-yang.yang29@zte.com.cn> (raw)
In-Reply-To: <643d62b28e413_29adc929416@willemb.c.googlers.com.notmuch>
> Why are you running two senders concurrently? The test is not intended
> to handle that case.
Sorry for the inaccuracy of the description here, these two commands,
i.e. with or without GSO, cause the problem. The same goes for patch 2/3.
The problem is easily reproducible in the latest kernel, QEMU environment, E1000.
bash# udpgso_bench_tx -l 4 -4 -D "$DST"
udpgso_bench_tx: write: Connection refused
bash# udpgso_bench_rx -4 -G -S 1472 -v
udpgso_bench_rx: data[1472]: len 17664, a(97) != q(113)
bash# udpgso_bench_tx -l 4 -4 -D "$DST" -S 0
udpgso_bench_tx: sendmsg: Connection refused
bash# udpgso_bench_rx -4 -G -S 1472 -v
udpgso_bench_rx: data[61824]: len 64768, a(97) != w(119)
In one test, the verification data is printed as follows:
abcd...xyz
...
abcd...xyz
abcd...opabcd...xyz
This is because the sender intercepts from the buf at a certain length,
which is not aligned according to 26 bytes, and multiple packets are
merged. The verification of the receiving end needs to be performed
after splitting.
next prev parent reply other threads:[~2023-04-18 1:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 12:17 [PATCH linux-next 0/3] selftests: net: udpgso_bench_rx: Fix verifty, gsosize, and packet number exceptions yang.yang29
2023-04-17 12:24 ` [PATCH linux-next 1/3] selftests: net: udpgso_bench_rx: Fix verifty exceptions Yang Yang
2023-04-17 15:16 ` Willem de Bruijn
2023-04-18 1:29 ` Yang Yang [this message]
2023-04-18 13:01 ` Willem de Bruijn
2023-04-18 14:20 ` Paolo Abeni
2023-04-17 12:24 ` [PATCH linux-next 2/3] selftests: net: udpgso_bench_rx: Fix gsosize exceptions Yang Yang
2023-04-17 12:25 ` [PATCH linux-next 3/3] selftests: net: udpgso_bench_rx: Fix packet number exceptions Yang Yang
2023-04-17 15:27 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418012910.194745-1-yang.yang29@zte.com.cn \
--to=yang.yang29@zte.com.cn \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiang.xuexin@zte.com.cn \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
--cc=xu.xin16@zte.com.cn \
--cc=zhang.yunkai@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox