Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: linux-kselftest@vger.kernel.org,
	Reinette Chatre <reinette.chatre@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>,
	linux-kernel@vger.kernel.org
Cc: "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v2 07/24] selftests/resctrl: Remove duplicated preparation for span arg
Date: Tue, 18 Apr 2023 14:44:49 +0300	[thread overview]
Message-ID: <20230418114506.46788-8-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20230418114506.46788-1-ilpo.jarvinen@linux.intel.com>

When no benchmark_cmd is given, benchmark_cmd[1] is set to span in
main(). There's no need to do it again in run_mba_test().

Remove the duplicated preparation for span argument into
benchmark_cmd[1] from run_mba_test(). It enables also removing has_ben
argument from run_mba_test() as unnecessary.

Co-developed-by: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
 tools/testing/selftests/resctrl/resctrl_tests.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
index f1ed2c89f228..3c8ec68eb507 100644
--- a/tools/testing/selftests/resctrl/resctrl_tests.c
+++ b/tools/testing/selftests/resctrl/resctrl_tests.c
@@ -99,8 +99,8 @@ static void run_mbm_test(bool has_ben, char **benchmark_cmd, unsigned long span,
 	umount_resctrlfs();
 }
 
-static void run_mba_test(bool has_ben, char **benchmark_cmd, unsigned long span,
-			 int cpu_no, char *bw_report)
+static void run_mba_test(char **benchmark_cmd, unsigned long span, int cpu_no,
+			 char *bw_report)
 {
 	int res;
 
@@ -117,8 +117,6 @@ static void run_mba_test(bool has_ben, char **benchmark_cmd, unsigned long span,
 		goto umount;
 	}
 
-	if (!has_ben)
-		sprintf(benchmark_cmd[1], "%lu", span);
 	res = mba_schemata_change(cpu_no, bw_report, benchmark_cmd);
 	ksft_test_result(!res, "MBA: schemata change\n");
 
@@ -297,7 +295,7 @@ int main(int argc, char **argv)
 		run_mbm_test(has_ben, benchmark_cmd, span, cpu_no, bw_report);
 
 	if (mba_test)
-		run_mba_test(has_ben, benchmark_cmd, span, cpu_no, bw_report);
+		run_mba_test(benchmark_cmd, span, cpu_no, bw_report);
 
 	if (cmt_test)
 		run_cmt_test(has_ben, benchmark_cmd, cpu_no);
-- 
2.30.2


  parent reply	other threads:[~2023-04-18 11:46 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-18 11:44 [PATCH v2 00/24] selftests/resctrl: Fixes, cleanups, and rewritten CAT test Ilpo Järvinen
2023-04-18 11:44 ` [PATCH v2 01/24] selftests/resctrl: Add resctrl.h into build deps Ilpo Järvinen
2023-04-22  0:07   ` Reinette Chatre
2023-04-18 11:44 ` [PATCH v2 02/24] selftests/resctrl: Check also too low values for CBM bits Ilpo Järvinen
2023-04-22  0:08   ` Reinette Chatre
2023-04-24 10:46     ` Ilpo Järvinen
2023-04-18 11:44 ` [PATCH v2 03/24] selftests/resctrl: Move resctrl FS mount/umount to higher level Ilpo Järvinen
2023-04-22  0:09   ` Reinette Chatre
2023-04-24 14:58     ` Ilpo Järvinen
2023-04-18 11:44 ` [PATCH v2 04/24] selftests/resctrl: Remove mum_resctrlfs Ilpo Järvinen
2023-04-22  0:11   ` Reinette Chatre
2023-04-24 14:55     ` Ilpo Järvinen
2023-04-18 11:44 ` [PATCH v2 05/24] selftests/resctrl: Make span unsigned long everywhere Ilpo Järvinen
2023-04-22  0:12   ` Reinette Chatre
2023-04-24 15:05     ` Ilpo Järvinen
2023-04-18 11:44 ` [PATCH v2 06/24] selftests/resctrl: Express span in bytes Ilpo Järvinen
2023-04-22  0:12   ` Reinette Chatre
2023-04-24 15:31     ` Ilpo Järvinen
2023-04-18 11:44 ` Ilpo Järvinen [this message]
2023-04-22  0:14   ` [PATCH v2 07/24] selftests/resctrl: Remove duplicated preparation for span arg Reinette Chatre
2023-04-24 15:41     ` Ilpo Järvinen
2023-04-18 11:44 ` [PATCH v2 08/24] selftests/resctrl: Don't use variable argument list for ->setup() Ilpo Järvinen
2023-04-18 11:44 ` [PATCH v2 09/24] selftests/resctrl: Remove "malloc_and_init_memory" param from run_fill_buf() Ilpo Järvinen
2023-04-18 11:44 ` [PATCH v2 10/24] selftests/resctrl: Split run_fill_buf() to alloc, work, and dealloc helpers Ilpo Järvinen
2023-04-22  0:16   ` Reinette Chatre
2023-04-24 16:01     ` Ilpo Järvinen
2023-04-24 16:32       ` Reinette Chatre
2023-04-18 11:44 ` [PATCH v2 11/24] selftests/resctrl: Remove start_buf local variable from buffer alloc func Ilpo Järvinen
2023-04-22  0:16   ` Reinette Chatre
2023-04-18 11:44 ` [PATCH v2 12/24] selftests/resctrl: Don't pass test name to fill_buf Ilpo Järvinen
2023-04-18 11:44 ` [PATCH v2 13/24] selftests/resctrl: Add flush_buffer() " Ilpo Järvinen
2023-04-22  0:16   ` Reinette Chatre
2023-04-18 11:44 ` [PATCH v2 14/24] selftests/resctrl: Remove test type checks from cat_val() Ilpo Järvinen
2023-04-18 11:44 ` [PATCH v2 15/24] selftests/resctrl: Refactor get_cbm_mask() Ilpo Järvinen
2023-04-22  0:17   ` Reinette Chatre
2023-05-31  6:03   ` Shaopeng Tan (Fujitsu)
2023-05-31  9:24     ` Ilpo Järvinen
2023-04-18 11:44 ` [PATCH v2 16/24] selftests/resctrl: Create cache_alloc_size() helper Ilpo Järvinen
2023-04-22  0:19   ` Reinette Chatre
2023-04-24 16:28     ` Ilpo Järvinen
2023-04-24 16:45       ` Reinette Chatre
2023-04-18 11:44 ` [PATCH v2 17/24] selftests/resctrl: Replace count_bits with count_consecutive_bits() Ilpo Järvinen
2023-04-22  0:20   ` Reinette Chatre
2023-04-25 11:41     ` Ilpo Järvinen
2023-04-25 14:28       ` Reinette Chatre
2023-05-31  7:25   ` Shaopeng Tan (Fujitsu)
2023-05-31  9:35     ` Ilpo Järvinen
2023-06-01  6:20       ` Shaopeng Tan (Fujitsu)
2023-04-18 11:45 ` [PATCH v2 18/24] selftests/resctrl: Exclude shareable bits from schemata in CAT test Ilpo Järvinen
2023-04-18 11:45 ` [PATCH v2 19/24] selftests/resctrl: Pass the real number of tests to show_cache_info() Ilpo Järvinen
2023-04-22  0:20   ` Reinette Chatre
2023-04-18 11:45 ` [PATCH v2 20/24] selftests/resctrl: Move CAT/CMT test global vars to func they are used Ilpo Järvinen
2023-04-22  0:20   ` Reinette Chatre
2023-04-18 11:45 ` [PATCH v2 21/24] selftests/resctrl: Read in less obvious order to defeat prefetch optimizations Ilpo Järvinen
2023-05-31  5:33   ` Shaopeng Tan (Fujitsu)
2023-05-31  9:17     ` Ilpo Järvinen
2023-06-01  6:15       ` Shaopeng Tan (Fujitsu)
2023-06-02 13:51         ` Ilpo Järvinen
2023-06-02 14:39           ` Reinette Chatre
2023-06-14 13:02         ` Ilpo Järvinen
2023-06-16  5:30           ` Shaopeng Tan (Fujitsu)
2023-06-16  6:44             ` Ilpo Järvinen
2023-04-18 11:45 ` [PATCH v2 22/24] selftests/resctrl: Split measure_cache_vals() function Ilpo Järvinen
2023-04-22  0:21   ` Reinette Chatre
2023-04-18 11:45 ` [PATCH v2 23/24] selftests/resctrl: Split show_cache_info() to test specific and generic parts Ilpo Järvinen
2023-04-22  0:22   ` Reinette Chatre
2023-04-18 11:45 ` [PATCH v2 24/24] selftests/resctrl: Rewrite Cache Allocation Technology (CAT) test Ilpo Järvinen
2023-04-22  0:32   ` Reinette Chatre
2023-04-26 13:58     ` Ilpo Järvinen
2023-04-26 23:35       ` Reinette Chatre
2023-04-27  8:04         ` Ilpo Järvinen
2023-04-27 15:15           ` Reinette Chatre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230418114506.46788-8-ilpo.jarvinen@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=shuah@kernel.org \
    --cc=tan.shaopeng@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox