From: Anders Roxell <anders.roxell@linaro.org>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org,
kernel@collabora.com, naresh.kamboju@linaro.org,
dan.carpenter@linaro.org
Subject: Re: [PATCH] selftests/mincore: fix skip condition for check_huge_pages test
Date: Wed, 17 May 2023 12:23:50 +0200 [thread overview]
Message-ID: <20230517102350.GB411@mutt> (raw)
In-Reply-To: <20230515132643.119809-1-ricardo.canuelo@collabora.com>
On 2023-05-15 15:26, Ricardo Cañuelo wrote:
> The check_huge_pages test was failing instead of skipping on qemu-armv7
> because the skip condition wasn't handled properly. Add an additional
> check to fix it.
>
> Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Closes: https://lore.kernel.org/all/CA+G9fYuoB8Ug8PcTU-YGmemL7_eeEksXFihvxWF6OikD7sK7pA@mail.gmail.com
Tested-by: Anders Roxell <anders.roxell@linaro.org>
This is how I tested it on Linux next tag: next-20230516. Installed
tuxmake [1], and tuxrun [2].
$ tuxmake --runtime podman --target-arch arm --toolchain gcc-12 \
--kconfig defconfig \
--kconfig-add https://raw.githubusercontent.com/Linaro/meta-lkft/kirkstone/meta/recipes-kernel/linux/files/lkft.config \
--kconfig-add https://raw.githubusercontent.com/Linaro/meta-lkft/kirkstone/meta/recipes-kernel/linux/files/systemd.config \
--kconfig-add CONFIG_ARM_TI_CPUFREQ=y --kconfig-add CONFIG_SERIAL_8250_OMAP=y --kconfig-add CONFIG_POSIX_MQUEUE=y \
--kconfig-add CONFIG_OF=y --kconfig-add CONFIG_SYN_COOKIES=y--kconfig-add CONFIG_SCHEDSTATS=y --kconfig-add CONFIG_AHCI_DWC=y \
dtbs dtbs-legacy headers kernel kselftest modules \
--results-hook "tuxrun --runtime podman --device qemu-armv7 --boot-args rw --tuxmake ./ --rootfs https://storage.tuxboot.com/debian/bookworm/armhf/rootfs.ext4.xz --parameters SKIPFILE=skipfile-lkft.yaml --parameters KSELFTEST='\$BUILD'/kselftest.tar.xz --tests kselftest-mincore --timeouts boot=30"
Cheers,
Anders
[1] https://tuxmake.org/
[2] https://tuxrun.org/
> ---
> tools/testing/selftests/mincore/mincore_selftest.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/mincore/mincore_selftest.c b/tools/testing/selftests/mincore/mincore_selftest.c
> index 4c88238fc8f0..6fb3eea5b6ee 100644
> --- a/tools/testing/selftests/mincore/mincore_selftest.c
> +++ b/tools/testing/selftests/mincore/mincore_selftest.c
> @@ -150,8 +149,8 @@ TEST(check_huge_pages)
> MAP_PRIVATE | MAP_ANONYMOUS | MAP_HUGETLB,
> -1, 0);
> if (addr == MAP_FAILED) {
> - if (errno == ENOMEM)
> - SKIP(return, "No huge pages available.");
> + if (errno == ENOMEM || errno == EINVAL)
> + SKIP(return, "No huge pages available or CONFIG_HUGETLB_PAGE disabled.");
> else
> TH_LOG("mmap error: %s", strerror(errno));
> }
> --
> 2.25.1
>
--
Anders Roxell
anders.roxell@linaro.org
M: +46 708 22 71 05 | IRC: roxell
next prev parent reply other threads:[~2023-05-17 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 13:26 [PATCH] selftests/mincore: fix skip condition for check_huge_pages test Ricardo Cañuelo
2023-05-17 10:23 ` Anders Roxell [this message]
2023-06-06 7:09 ` Ricardo Cañuelo
2023-06-06 8:04 ` Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517102350.GB411@mutt \
--to=anders.roxell@linaro.org \
--cc=dan.carpenter@linaro.org \
--cc=kernel@collabora.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=ricardo.canuelo@collabora.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox