From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69879C7EE2E for ; Tue, 13 Jun 2023 10:25:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241707AbjFMKZu (ORCPT ); Tue, 13 Jun 2023 06:25:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242189AbjFMKZU (ORCPT ); Tue, 13 Jun 2023 06:25:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F2801984; Tue, 13 Jun 2023 03:24:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 17B1560CA5; Tue, 13 Jun 2023 10:24:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31AB3C433D2; Tue, 13 Jun 2023 10:24:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1686651856; bh=kmBMMIwD/yv1wQlDFbuD7w3rwb8n0X0M2t781svCHZw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eKJchQZffSxtukjB8t6lkEW9i+DIy54ptlyPirr2IakXGGwhXltdxh9eVr5UPHmV0 jHaxTOKMLsLffeh+r97kMT3MzZcfKX8dLjz+L2EYoZVOTKtvmz0gC5rWrUR9DkZGq0 GUUmGngWcdw7fLS2O9jGUJudTaL0p4hwuGtKHTuE= Date: Tue, 13 Jun 2023 12:24:14 +0200 From: Greg KH To: Michal Sekletar Cc: jirislaby@kernel.org, arozansk@redhat.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org Subject: Re: [PATCH v2 1/2] tty: tty_io: update timestamps on all device nodes Message-ID: <2023061359-document-armband-d67d@gregkh> References: <20230608101616.44152-1-msekleta@redhat.com> <2023060816-quicken-around-d619@gregkh> <2023061325-alibi-grappling-c764@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2023061325-alibi-grappling-c764@gregkh> Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Tue, Jun 13, 2023 at 12:23:41PM +0200, Greg KH wrote: > On Thu, Jun 08, 2023 at 07:52:54PM +0200, Michal Sekletar wrote: > > On Thu, Jun 8, 2023 at 1:51 PM Greg KH wrote: > > > > > So how are you protecting this from being an information leak like we > > > have had in the past where you could monitor how many characters were > > > being sent to the tty through a proc file? Seems like now you can just > > > monitor any tty node in the system and get the same information, while > > > today you can only do it for the tty devices you have permissions for, > > > right? > > > > Hi Greg, > > > > I am not protecting against it in any way, but proposed changes are only > > about timestamp updates which still happen in at least 8 seconds intervals > > so exact timing of read/writes to tty can't be inferred. Frankly, I may > > have misunderstood something. It would be great if you could mention a bit > > more details about CVE you had in mind. > > Ah, I missed that this is in 8 second increments, nevermind then! > Note, I still can't take this series for the obvious reason in patch 2/2. Please fix. thanks, greg k-h