From: David Disseldorp <ddiss@suse.de>
To: Shuah Khan <shuah@kernel.org>
Cc: linux-kselftest@vger.kernel.org, "Michal Koutný" <mkoutny@suse.com>
Subject: Re: [PATCH] selftests/zram: avoid subshells and bc for ratio calculations
Date: Wed, 28 Jun 2023 13:03:10 +0200 [thread overview]
Message-ID: <20230628130310.416769d5@echidna.fritz.box> (raw)
In-Reply-To: <20230628105345.16952-1-ddiss@suse.de>
One minor follow up...
On Wed, 28 Jun 2023 12:53:45 +0200, David Disseldorp wrote:
> Awk is already called for /sys/block/zram#/mm_stat parsing, so use it
> to also perform the floating point capacity vs consumption ratio
> calculations. The test output is unchanged.
> This allows bc to be dropped as a dependency for the zram selftests.
It looks as though the following hunk should also be squashed in. free
usage was dropped with d18da7ec3719559d6e74937266d0416e6c7e0b31:
--- a/tools/testing/selftests/zram/README
+++ b/tools/testing/selftests/zram/README
@@ -27,9 +27,7 @@ zram01.sh: creates general purpose ram disks with ext4 filesystems
zram02.sh: creates block device for swap
Commands required for testing:
- - bc
- dd
- - free
- awk
- mkswap
- swapon
prev parent reply other threads:[~2023-06-28 11:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 10:53 [PATCH] selftests/zram: avoid subshells and bc for ratio calculations David Disseldorp
2023-06-28 11:03 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230628130310.416769d5@echidna.fritz.box \
--to=ddiss@suse.de \
--cc=linux-kselftest@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox