From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61A8DEB64D9 for ; Sun, 2 Jul 2023 16:44:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229604AbjGBQoL (ORCPT ); Sun, 2 Jul 2023 12:44:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229516AbjGBQoK (ORCPT ); Sun, 2 Jul 2023 12:44:10 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2635812A; Sun, 2 Jul 2023 09:44:08 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 362Ghw98016406; Sun, 2 Jul 2023 18:43:58 +0200 Date: Sun, 2 Jul 2023 18:43:58 +0200 From: Willy Tarreau To: Zhangjin Wu Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, thomas@t-8ch.de Subject: Re: [PATCH v2 0/3] selftests/nolibc: improve test report support Message-ID: <20230702164358.GB16233@1wt.eu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Hi Zhangjin, On Mon, Jun 19, 2023 at 02:52:31PM +0800, Zhangjin Wu wrote: > Hi, Willy > > Here is the v2 of our old patchset about test report [1]. > > The trailing '\r' fixup has been merged, so, here only resend the left > parts with an additional patch to restore the failed tests print. > > This patchset is rebased on the dev.2023.06.14a branch of linux-rcu [2]. > > Tests have passed for 'x86 run': > > 138 test(s) passed, 0 skipped, 0 failed. > See all results in /labs/linux-lab/src/linux-stable/tools/testing/selftests/nolibc/run.out (...) > 2. selftests/nolibc: always print the path to test log file > > Always print the path to test log file, but move it to a new line to > avoid annoying people when the test pass without any failures. I'm still really missing the (s+f > 0) test I added which was a time saver for me, because I could trivially check in the output reports which ones were totally OK and which ones required attention. Sure I could also start to grep for "passed," | grep -v " 0 skipped, 0 failed" but that's quite a pain, really. I'm going to merge your series anyway otherwise we'll continue to bikeshed for many weeks and I know how annoying it is to keep unmerged series. But I would like that we find a solution that satisfies everyone. Maybe one possibility would be to add a "status" at the end of the line that emits "success", "warning", "failure" depending on the highest level reached like this: 138 test(s) passed, 0 skipped, 0 failed => status: success 136 test(s) passed, 2 skipped, 0 failed => status: warning 136 test(s) passed, 1 skipped, 1 failed => status: failure This way it's easy to grep -v "status: success" or grep "status: failure" to instantly get the corresponding details and also grep for them from multiple files. Thanks! Willy