From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F8B6EB64DC for ; Tue, 11 Jul 2023 19:13:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230331AbjGKTNF (ORCPT ); Tue, 11 Jul 2023 15:13:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231368AbjGKTNC (ORCPT ); Tue, 11 Jul 2023 15:13:02 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 12702EA; Tue, 11 Jul 2023 12:12:56 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 36BJCX04006335; Tue, 11 Jul 2023 21:12:33 +0200 Date: Tue, 11 Jul 2023 21:12:33 +0200 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Zhangjin Wu Subject: Re: [PATCH 3/4] selftests/nolibc: simplify status argument Message-ID: <20230711191233.GB31402@1wt.eu> References: <20230711-nolibc-sizeof-long-gaps-v1-0-dc78c3b85fc3@weissschuh.net> <20230711-nolibc-sizeof-long-gaps-v1-3-dc78c3b85fc3@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230711-nolibc-sizeof-long-gaps-v1-3-dc78c3b85fc3@weissschuh.net> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Hi Thomas, On Tue, Jul 11, 2023 at 11:48:41AM +0200, Thomas Weißschuh wrote: > I'm not sure if this is an improvement over the previous patch. > If so it should be squashed into it. Indeed, I find it less readable, because when you read: result(llen, ret ? FAIL : OK); it makes it explicit what values of ret are expected with what meaning, but this one: result(llen, ret); makes it quite opaque. I'd rather keep the ternary operator and the 3 values that are likely more accessible to newcomers who will more quickly figure how to do what they need. Thus I dropped this one and applied the 3 other ones which are indeed a nice cleanup. Thanks, Willy