From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B047C001DB for ; Mon, 14 Aug 2023 07:17:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232918AbjHNHQw (ORCPT ); Mon, 14 Aug 2023 03:16:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234071AbjHNHQl (ORCPT ); Mon, 14 Aug 2023 03:16:41 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 45B3FE71; Mon, 14 Aug 2023 00:16:34 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 37E7GLEA016686; Mon, 14 Aug 2023 09:16:21 +0200 Date: Mon, 14 Aug 2023 09:16:21 +0200 From: Willy Tarreau To: Zhangjin Wu Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, tanyuan@tinylab.org, thomas@t-8ch.de Subject: Re: [PATCH v2 5/7] selftests/nolibc: customize CROSS_COMPILE for all architectures Message-ID: <20230814071621.GB14322@1wt.eu> References: <20230813091625.GG8237@1wt.eu> <20230813101805.10885-1-falcon@tinylab.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230813101805.10885-1-falcon@tinylab.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Sun, Aug 13, 2023 at 06:18:05PM +0800, Zhangjin Wu wrote: > > Given that we don't support mips64, I'd suggest to ust mips-linux- > > instead here for now. That doesn't seem right to ask users to > > download a toolchain for a different architecture than the one > > supported just because we can adapt to it. > > > > Agree very much, and the one below from patch 7/7 [1]: > > +CROSS_COMPILE_arm64 ?= aarch64-linux- aarch64-linux-gnu- > +CROSS_COMPILE_arm ?= arm-linux-gnueabi- arm-none-eabi- > +CROSS_COMPILE_mips ?= mips64-linux- mips64el-linux-gnuabi64- > > It should be: > > +CROSS_COMPILE_mips ?= mips-linux- mips-linux-gnu-gcc > > And if necessary, the mips64-linux- line in the commit message of [1] should be > corrected too. I just did that (and fixed mips-linux-gnu- instead of mips-linux-gnu-gcc above). Thanks, Willy