From: Puranjay Mohan <puranjay12@gmail.com>
To: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
Shubham Bansal <illusionist.neo@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Mykola Lysenko <mykolal@fb.com>, Shuah Khan <shuah@kernel.org>,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: puranjay12@gmail.com
Subject: [PATCH bpf-next v3 1/9] arm32, bpf: add support for 32-bit offset jmp instruction
Date: Thu, 7 Sep 2023 23:05:42 +0000 [thread overview]
Message-ID: <20230907230550.1417590-2-puranjay12@gmail.com> (raw)
In-Reply-To: <20230907230550.1417590-1-puranjay12@gmail.com>
The cpuv4 adds unconditional jump with 32-bit offset where the immediate
field of the instruction is to be used to calculate the jump offset.
BPF_JA | BPF_K | BPF_JMP32 => gotol +imm => PC += imm.
Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
arch/arm/net/bpf_jit_32.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c
index 6a1c9fca5260..c03600fe86f6 100644
--- a/arch/arm/net/bpf_jit_32.c
+++ b/arch/arm/net/bpf_jit_32.c
@@ -1761,10 +1761,15 @@ static int build_insn(const struct bpf_insn *insn, struct jit_ctx *ctx)
break;
/* JMP OFF */
case BPF_JMP | BPF_JA:
+ case BPF_JMP32 | BPF_JA:
{
- if (off == 0)
+ if (BPF_CLASS(code) == BPF_JMP32 && imm != 0)
+ jmp_offset = bpf2a32_offset(i + imm, i, ctx);
+ else if (BPF_CLASS(code) == BPF_JMP && off != 0)
+ jmp_offset = bpf2a32_offset(i + off, i, ctx);
+ else
break;
- jmp_offset = bpf2a32_offset(i+off, i, ctx);
+
check_imm24(jmp_offset);
emit(ARM_B(jmp_offset), ctx);
break;
--
2.39.2
next prev parent reply other threads:[~2023-09-07 23:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 23:05 [PATCH bpf-next v3 0/9] arm32, bpf: add support for cpuv4 insns Puranjay Mohan
2023-09-07 23:05 ` Puranjay Mohan [this message]
2023-09-07 23:05 ` [PATCH bpf-next v3 2/9] arm32, bpf: add support for sign-extension load instruction Puranjay Mohan
2023-09-07 23:05 ` [PATCH bpf-next v3 3/9] arm32, bpf: add support for sign-extension mov instruction Puranjay Mohan
2023-09-07 23:05 ` [PATCH bpf-next v3 4/9] arm32, bpf: add support for unconditional bswap instruction Puranjay Mohan
2023-09-08 8:34 ` Russell King (Oracle)
2023-09-07 23:05 ` [PATCH bpf-next v3 5/9] arm32, bpf: add support for 32-bit signed division Puranjay Mohan
2023-09-07 23:05 ` [PATCH bpf-next v3 6/9] arm32, bpf: add support for 64 bit division instruction Puranjay Mohan
2023-09-08 8:36 ` Russell King (Oracle)
2023-09-07 23:05 ` [PATCH bpf-next v3 7/9] selftest, bpf: enable cpu v4 tests for arm32 Puranjay Mohan
2023-09-07 23:05 ` [PATCH bpf-next v3 8/9] bpf/tests: add tests for cpuv4 instructions Puranjay Mohan
2023-09-26 6:45 ` kernel test robot
2023-09-07 23:05 ` [PATCH bpf-next v3 9/9] MAINTAINERS: Add myself for ARM32 BPF JIT maintainer Puranjay Mohan
2023-09-08 8:37 ` Russell King (Oracle)
2023-09-08 8:38 ` Puranjay Mohan
2023-09-08 13:49 ` Daniel Borkmann
2023-09-08 14:49 ` Puranjay Mohan
2023-09-16 0:18 ` Alexei Starovoitov
2023-09-16 0:20 ` [PATCH bpf-next v3 0/9] arm32, bpf: add support for cpuv4 insns patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230907230550.1417590-2-puranjay12@gmail.com \
--to=puranjay12@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=illusionist.neo@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox