[PATCH v6] selftests: rtc: Fixes rtctest error handling.

[PATCH v6] selftests: rtc: Fixes rtctest error handling.

[Atul Kumar Pant]

Adds a check to verify if the rtc device file is valid or not
and prints a useful error message if the file is not accessible.

Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
---

changes since v5:
    Updated error message to use strerror().
	If the rtc file is invalid, the skip the test.

changes since v4:
    Updated the commit message.

changes since v3:
    Added Linux-kselftest and Linux-kernel mailing lists.

changes since v2:
    Changed error message when rtc file does not exist.

changes since v1:
    Removed check for uid=0
    If rtc file is invalid, then exit the test.

 tools/testing/selftests/rtc/rtctest.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/rtc/rtctest.c b/tools/testing/selftests/rtc/rtctest.c
index 630fef735c7e..27b466111885 100644
--- a/tools/testing/selftests/rtc/rtctest.c
+++ b/tools/testing/selftests/rtc/rtctest.c
@@ -15,6 +15,7 @@
 #include <sys/types.h>
 #include <time.h>
 #include <unistd.h>
+#include <error.h>
 
 #include "../kselftest_harness.h"
 #include "../kselftest.h"
@@ -437,7 +438,7 @@ int main(int argc, char **argv)
 	if (access(rtc_file, F_OK) == 0)
 		ret = test_harness_run(argc, argv);
 	else
-		ksft_exit_fail_msg("[ERROR]: Cannot access rtc file %s - Exiting\n", rtc_file);
+		ksft_exit_skip("%s: %s\n", rtc_file, strerror(errno));
 
 	return ret;
 }
-- 
2.25.1

Re: [PATCH v6] selftests: rtc: Fixes rtctest error handling.

[Atul Kumar Pant]

On Thu, Aug 17, 2023 at 02:44:01PM +0530, Atul Kumar Pant wrote:
> Adds a check to verify if the rtc device file is valid or not
> and prints a useful error message if the file is not accessible.
> 
> Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
> ---
> 
> changes since v5:
>     Updated error message to use strerror().
> 	If the rtc file is invalid, the skip the test.
> 
> changes since v4:
>     Updated the commit message.
> 
> changes since v3:
>     Added Linux-kselftest and Linux-kernel mailing lists.
> 
> changes since v2:
>     Changed error message when rtc file does not exist.
> 
> changes since v1:
>     Removed check for uid=0
>     If rtc file is invalid, then exit the test.
> 
>  tools/testing/selftests/rtc/rtctest.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/rtc/rtctest.c b/tools/testing/selftests/rtc/rtctest.c
> index 630fef735c7e..27b466111885 100644
> --- a/tools/testing/selftests/rtc/rtctest.c
> +++ b/tools/testing/selftests/rtc/rtctest.c
> @@ -15,6 +15,7 @@
>  #include <sys/types.h>
>  #include <time.h>
>  #include <unistd.h>
> +#include <error.h>
>  
>  #include "../kselftest_harness.h"
>  #include "../kselftest.h"
> @@ -437,7 +438,7 @@ int main(int argc, char **argv)
>  	if (access(rtc_file, F_OK) == 0)
>  		ret = test_harness_run(argc, argv);
>  	else
> -		ksft_exit_fail_msg("[ERROR]: Cannot access rtc file %s - Exiting\n", rtc_file);
> +		ksft_exit_skip("%s: %s\n", rtc_file, strerror(errno));
>  
>  	return ret;
>  }
> -- 
> 2.25.1
> 

	Hi Shuah, I have made the changes as per your comments. Can you please
	review the changes ?

Re: [PATCH v6] selftests: rtc: Fixes rtctest error handling.

[Atul Kumar Pant]

On Sat, Sep 23, 2023 at 11:06:58PM +0530, Atul Kumar Pant wrote:
> On Thu, Aug 17, 2023 at 02:44:01PM +0530, Atul Kumar Pant wrote:
> > Adds a check to verify if the rtc device file is valid or not
> > and prints a useful error message if the file is not accessible.
> > 
> > Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
> > ---
> > 
> > changes since v5:
> >     Updated error message to use strerror().
> > 	If the rtc file is invalid, the skip the test.
> > 
> > changes since v4:
> >     Updated the commit message.
> > 
> > changes since v3:
> >     Added Linux-kselftest and Linux-kernel mailing lists.
> > 
> > changes since v2:
> >     Changed error message when rtc file does not exist.
> > 
> > changes since v1:
> >     Removed check for uid=0
> >     If rtc file is invalid, then exit the test.
> > 
> >  tools/testing/selftests/rtc/rtctest.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/testing/selftests/rtc/rtctest.c b/tools/testing/selftests/rtc/rtctest.c
> > index 630fef735c7e..27b466111885 100644
> > --- a/tools/testing/selftests/rtc/rtctest.c
> > +++ b/tools/testing/selftests/rtc/rtctest.c
> > @@ -15,6 +15,7 @@
> >  #include <sys/types.h>
> >  #include <time.h>
> >  #include <unistd.h>
> > +#include <error.h>
> >  
> >  #include "../kselftest_harness.h"
> >  #include "../kselftest.h"
> > @@ -437,7 +438,7 @@ int main(int argc, char **argv)
> >  	if (access(rtc_file, F_OK) == 0)
> >  		ret = test_harness_run(argc, argv);
> >  	else
> > -		ksft_exit_fail_msg("[ERROR]: Cannot access rtc file %s - Exiting\n", rtc_file);
> > +		ksft_exit_skip("%s: %s\n", rtc_file, strerror(errno));
> >  
> >  	return ret;
> >  }
> > -- 
> > 2.25.1
> > 
> 
> 	Hi Shuah, I have made the changes as per your comments. Can you please
> 	review the changes ?

	Hi Shuah, can you please review the changes and provide comments ?
	It has been quite sometime since I uploaded the change. If something
	is to be improved, I'll gladly do it.

Re: [PATCH v6] selftests: rtc: Fixes rtctest error handling.

[Shuah Khan]

On 10/7/23 09:43, Atul Kumar Pant wrote:
> On Sat, Sep 23, 2023 at 11:06:58PM +0530, Atul Kumar Pant wrote:
>> On Thu, Aug 17, 2023 at 02:44:01PM +0530, Atul Kumar Pant wrote:
>>> Adds a check to verify if the rtc device file is valid or not
>>> and prints a useful error message if the file is not accessible.
>>>
>>> Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
>>> ---


Sorry for the delay. I will pick this up for the next rc.

thanks,
-- Shuah

Re: [PATCH v6] selftests: rtc: Fixes rtctest error handling.

[Atul Kumar Pant]

On Tue, Nov 07, 2023 at 02:27:35PM -0700, Shuah Khan wrote:
> On 10/7/23 09:43, Atul Kumar Pant wrote:
> > On Sat, Sep 23, 2023 at 11:06:58PM +0530, Atul Kumar Pant wrote:
> > > On Thu, Aug 17, 2023 at 02:44:01PM +0530, Atul Kumar Pant wrote:
> > > > Adds a check to verify if the rtc device file is valid or not
> > > > and prints a useful error message if the file is not accessible.
> > > > 
> > > > Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
> > > > ---
> 
> 
> Sorry for the delay. I will pick this up for the next rc.
> 
> thanks,
> -- Shuah

	Thanks Shuah