From: Greg KH <gregkh@linuxfoundation.org>
To: Abhinav <singhabhinav9051571833@gmail.com>
Cc: shuah@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] Added missing TARGETS in kselftest top level Makefile
Date: Sun, 1 Oct 2023 08:07:25 +0200 [thread overview]
Message-ID: <2023100135-stiffen-depress-8121@gregkh> (raw)
In-Reply-To: <20230930194106.1379527-1-singhabhinav9051571833@gmail.com>
On Sun, Oct 01, 2023 at 01:11:06AM +0530, Abhinav wrote:
> Some TARGETS were missing in selftests top level Makefile.Added those.
> Signed-off-by: Abhinav <singhabhinav9051571833@gmail.com>
You need a blank line here please.
Also, why make this change, you are saying what you did, but not why?
Have you tested to verify that these targets were actually missing and
needed to be added? If so, for what reason?
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-01 6:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 19:41 [PATCH] Added missing TARGETS in kselftest top level Makefile Abhinav
2023-10-01 6:07 ` Greg KH [this message]
2023-10-02 7:27 ` [PATCH v2] " Abhinav
2023-10-02 8:58 ` Greg KH
2023-10-02 11:46 ` Abhinav
2023-10-02 14:34 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023100135-stiffen-depress-8121@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=singhabhinav9051571833@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox