Re: [PATCH v3 1/5] workqueue: Make workqueue_set_unbound_cpumask() static

Waiman Long
2023-11-15T21:18:07Z

On 11/15/23 14:12, kernel test robot wrote:
> Hi Waiman,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on shuah-kselftest/next]
> [also build test WARNING on shuah-kselftest/fixes linus/master v6.7-rc1]
> [cannot apply to tj-cgroup/for-next tj-wq/for-next next-20231115]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Waiman-Long/workqueue-Make-workqueue_set_unbound_cpumask-static/20231116-010940
> base: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next
> patch link: https://lore.kernel.org/r/20231115170359.163299-2-longman%40redhat.com
> patch subject: [PATCH v3 1/5] workqueue: Make workqueue_set_unbound_cpumask() static
> config: i386-tinyconfig (https://download.01.org/0day-ci/archive/20231116/202311160353.FAdfQwO3-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231116/202311160353.FAdfQwO3-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202311160353.FAdfQwO3-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
>>> kernel/workqueue.c:4421:13: warning: 'apply_wqattrs_unlock' defined but not used [-Wunused-function]
> 4421 | static void apply_wqattrs_unlock(void)
> | ^~~~~~~~~~~~~~~~~~~~
>>> kernel/workqueue.c:4414:13: warning: 'apply_wqattrs_lock' defined but not used [-Wunused-function]
> 4414 | static void apply_wqattrs_lock(void)
> | ^~~~~~~~~~~~~~~~~~
>
>
> vim +/apply_wqattrs_unlock +4421 kernel/workqueue.c
>
> 8864b4e59f7945 Tejun Heo 2013-03-12 4413
> a0111cf6710bd1 Lai Jiangshan 2015-05-19 @4414 static void apply_wqattrs_lock(void)
> a0111cf6710bd1 Lai Jiangshan 2015-05-19 4415 {
> a0111cf6710bd1 Lai Jiangshan 2015-05-19 4416 /* CPUs should stay stable across pwq creations and installations */
> ffd8bea81fbb5a Sebastian Andrzej Siewior 2021-08-03 4417 cpus_read_lock();
> a0111cf6710bd1 Lai Jiangshan 2015-05-19 4418 mutex_lock(&wq_pool_mutex);
> a0111cf6710bd1 Lai Jiangshan 2015-05-19 4419 }
> a0111cf6710bd1 Lai Jiangshan 2015-05-19 4420
> a0111cf6710bd1 Lai Jiangshan 2015-05-19 @4421 static void apply_wqattrs_unlock(void)
> a0111cf6710bd1 Lai Jiangshan 2015-05-19 4422 {
> a0111cf6710bd1 Lai Jiangshan 2015-05-19 4423 mutex_unlock(&wq_pool_mutex);
> ffd8bea81fbb5a Sebastian Andrzej Siewior 2021-08-03 4424 cpus_read_unlock();
> a0111cf6710bd1 Lai Jiangshan 2015-05-19 4425 }
> a0111cf6710bd1 Lai Jiangshan 2015-05-19 4426
>
OK, there are more functions that are CONFIG_SYSFS specific and need to
be moved as well.

Will post another version to fix that :-(

Regards,
Longman