Re: [PATCHv2 net-next 10/14] selftests/net: convert ioam6.sh to run it in unique namespace

Justin Iurman
2023-11-30T13:38:10Z

On 11/30/23 05:01, Hangbin Liu wrote:
> Here is the test result after conversion.
>
> ]# ./ioam6.sh
>
> --------------------------------------------------------------------------
> OUTPUT tests
> --------------------------------------------------------------------------
> TEST: Unknown IOAM namespace (inline mode) [ OK ]
> TEST: Unknown IOAM namespace (encap mode) [ OK ]
> TEST: Missing trace room (inline mode) [ OK ]
> TEST: Missing trace room (encap mode) [ OK ]
> TEST: Trace type with bit 0 only (inline mode) [ OK ]
> ...
> TEST: Full supported trace (encap mode) [ OK ]
>
> --------------------------------------------------------------------------
> GLOBAL tests
> --------------------------------------------------------------------------
> TEST: Forward - Full supported trace (inline mode) [ OK ]
> TEST: Forward - Full supported trace (encap mode) [ OK ]
>
> - Tests passed: 88
> - Tests failed: 0
>
> Acked-by: David Ahern <dsahern@kernel.org>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

Reviewed-by: Justin Iurman <justin.iurman@uliege.be>

LGTM. Just one question though. Is there any reason not to use
cleanup_ns everywhere? There is the following diff (actually, 3 times):

> - ip netns del ioam-tmp-node || true
> + ip netns del $ioam_tmp_node || true

While, at the same time, there is the following diff (as expected):

> - ip netns del ioam-node-alpha || true
> - ip netns del ioam-node-beta || true
> - ip netns del ioam-node-gamma || true
> + cleanup_ns $ioam_node_alpha $ioam_node_beta $ioam_node_gamma

IMO, it looks like cleanup_ns can safely replace all "ip netns del"
instances in ioam6.sh.