Re: [PATCH v4 1/5] kunit: Add APIs for managing devices

Greg Kroah-Hartman
2023-12-15T16:24:25Z

On Fri, Dec 15, 2023 at 03:39:08PM +0800, davidgow@google.com wrote:
> Tests for drivers often require a struct device to pass to other
> functions. While it's possible to create these with
> root_device_register(), or to use something like a platform device, this
> is both a misuse of those APIs, and can be difficult to clean up after,
> for example, a failed assertion.
>
> Add some KUnit-specific functions for registering and unregistering a
> struct device:
> - kunit_device_register()
> - kunit_device_register_with_driver()
> - kunit_device_unregister()
>
> These helpers allocate a on a 'kunit' bus which will either probe the
> driver passed in (kunit_device_register_with_driver), or will create a
> stub driver (kunit_device_register) which is cleaned up on test shutdown.
>
> Devices are automatically unregistered on test shutdown, but can be
> manually unregistered earlier with kunit_device_unregister() in order
> to, for example, test device release code.
>
> Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
> Reviewed-by: Maxime Ripard <mripard@kernel.org>
> Signed-off-by: David Gow <davidgow@google.com>

Nice work!

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>