From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B64083D97D for ; Thu, 22 Feb 2024 13:02:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708606967; cv=none; b=ZcXHo2rs8fqSJ/S84m6LQL+vwP15J7JV8qm9tRHNiXaEnONKW4IOYWOixoim5n7A+uUmyTisW6R1YgCKAnbOCevKadU5cwS7Wlz9DxP/4cymMOoXdK4Jc0FopPAkbY7o/I+cCy5jDaGzjsslQUxAHoLjv23sw2W5x7NFBVzVwQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708606967; c=relaxed/simple; bh=mLihlxLtwpBjewJipEa6FRB39ptkzFSdsuzkpNHKxJI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PkTobcmmSIq2X67Wwb47U8hNa78ilewYnJtuaPTxFUeDgb3+laMziI2QwWPit22nHM/2MxGkLTZMxIMrTD6n8JnscxV4JdUialJwGmw8/BEz37M3FaTXkSrvp4ybCgp+7RK7xgt/Se3zi5BH0TNpRrWdyvHP/343GK9p8iD6OoM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=kG6nU4Z7; arc=none smtp.client-ip=209.85.219.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="kG6nU4Z7" Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-68f51c5f9baso29351766d6.3 for ; Thu, 22 Feb 2024 05:02:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1708606962; x=1709211762; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=5AaVii71/VY2wZ+q8F0jNvSLMQ/WesHh9hxpdt+FDPE=; b=kG6nU4Z7+Q6FCz463hLsA756uwb15cy542whL12gyDB4rgN8f7anLjDdi0ntm7SzK2 r3dNrCWKpP6gRFDjSxaLeg7sx4x9EgLzKV44m/Wt7KIsjfHTWHFiseYP4FJwgTcaxyGZ ojwQiCz8i8FW4fzcczIPtm//dbX3YhF9aG1DdNrYtQZ2TtPx57SVauEdvwoGxygS+SLT AmZWVQPDM+lNNB2g+0dkBqGNv4CCegMayaSA6Nul2jc7KJrLoQaHHOFfgYDfDtfXIhvQ DK+3sak3puL+6TN1AnOhnBC8JoQLVPgGESNhhm6Dmwta2W699g/kBYDnnN8mqbIkPuhf gKQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708606962; x=1709211762; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5AaVii71/VY2wZ+q8F0jNvSLMQ/WesHh9hxpdt+FDPE=; b=gjSmMqQJZtCO/Tmb6NnQK7HIOfuVrSInq5zts057GXVzOjvXpsEeu0/IG3uzLa3AP9 nOtIbo9bXGbKpYZZfE4RIF4mHQyxuu1HA5wSGZvGXNrpS9MeuN1oiRfqokoE+PsDdMpV RD9nPFn4EtVP5cYM0tkvmHhKXwjd9lZ6+s4Q3PJL42gSXYcPNdzhr6nIIyf/r2vYT/vI opQcW5OldtO3vilTFHQyQl0oXNLp3gbU+BCPxKwIidG1p9AgtmWLFtgtkCMpgDOgJOgm p1x0vP9VJna5GdU3/jR5kih7Bm9aQ82Mlpva79oaG3AuQ7sVZKyuyxMf3fZ84FDEhVb5 9qpQ== X-Forwarded-Encrypted: i=1; AJvYcCVOu7Kp0v48Z7uYWraLODt9UGRcW8vLelmqQe8ERWXuAF6CFw2S6UNfQk2wzgvypr9/3oQd7es5pJA1Malef15erKCBAtuqEqQMs2MvKv1Q X-Gm-Message-State: AOJu0YyoPsfk3h5m7cYJFHJFHs/XyiVqTGMRemW7TpJJOfPIJJcZD1Io 19d3HLxJwrtEn3CMSp58ubyQt0U6h58XLTaJNaCJyLGhsBlRdfw0yJCgmTr4Jhc= X-Google-Smtp-Source: AGHT+IGAK7E+kzRE8+YA/j2lb1I8Y61tiNcJdozr2Qvcpk6aaDKEVgEQPQJ+SEeGp2gh8IK9zaw/sg== X-Received: by 2002:a0c:da82:0:b0:68f:2c72:a76a with SMTP id z2-20020a0cda82000000b0068f2c72a76amr22568368qvj.3.1708606962586; Thu, 22 Feb 2024 05:02:42 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-80-239.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.80.239]) by smtp.gmail.com with ESMTPSA id qm18-20020a056214569200b0068c88a31f1bsm1309293qvb.89.2024.02.22.05.02.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 05:02:42 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1rd8im-00G85D-DJ; Thu, 22 Feb 2024 09:02:40 -0400 Date: Thu, 22 Feb 2024 09:02:40 -0400 From: Jason Gunthorpe To: Muhammad Usama Anjum Cc: Kevin Tian , Shuah Khan , Yi Liu , Nicolin Chen , kernel@collabora.com, iommu@lists.linux.dev, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/iommu: fix the config fragment Message-ID: <20240222130240.GA3220539@ziepe.ca> References: <20240222074934.71380-1-usama.anjum@collabora.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240222074934.71380-1-usama.anjum@collabora.com> On Thu, Feb 22, 2024 at 12:49:33PM +0500, Muhammad Usama Anjum wrote: > The config fragment doesn't follow the correct format to enable those > config options which make the config options getting missed while > merging with other configs. > > ➜ merge_config.sh -m .config tools/testing/selftests/iommu/config > Using .config as base > Merging tools/testing/selftests/iommu/config > ➜ make olddefconfig > .config:5295:warning: unexpected data: CONFIG_IOMMUFD > .config:5296:warning: unexpected data: CONFIG_IOMMUFD_TEST > > While at it, add CONFIG_FAULT_INJECTION as well which is needed for > CONFIG_IOMMUFD_TEST. If CONFIG_FAULT_INJECTION isn't present in base > config (such as x86 defconfig), CONFIG_IOMMUFD_TEST doesn't get enabled. > > Fixes: 57f0988706fe ("iommufd: Add a selftest") > Signed-off-by: Muhammad Usama Anjum > --- > tools/testing/selftests/iommu/config | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Appled, thanks Jason