From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB1F4107B6 for ; Mon, 4 Mar 2024 20:58:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709585899; cv=none; b=IyrSblsglhl49Yb62Zk7u3Xwy41NC2EGPzl2EmEWHYYvAL07L5fcc92l2cBM2NTWhHkVpMwLK2Yvv2//AL4Y+MkU8sgSnKBLW0SzZEbLBZyuHI1O89YCa12LwjN5qXdprGkQDLGS5YX7YhN6nX0N9CEWVNrJawOwP653B1wgnFs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709585899; c=relaxed/simple; bh=vdK6RiW/KweEb9A7JW6V9Ozhw2b+gLO9iT+16Hcypr8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uqsjxq54yeFT0r9w+5mhYfQdIm/0ZyYJujIW6/SjvgykmH0DctE1YfX0K+fbl5o+I2GrKkSv06cvU+aMsLJq51YWMAFzj6tTdSH8SbiCAJLmPg4V5p3AYQbycsKZqpRrEjXOVcgP8Mkpkh/J96sPRcIB4emJh8ZUgzTSIasgQgY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=JTg4ctT2; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="JTg4ctT2" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1dd0d46ecc3so11902345ad.2 for ; Mon, 04 Mar 2024 12:58:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709585897; x=1710190697; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MBysldzXTflPzomKWRmSMXhF54SNqFAu7g8kqMxzJW8=; b=JTg4ctT2hzSBE5HZLwwuwqL52LNpw/pz84iJ+Lm9UnxvXgd8xleoD04qL6ScUAL+gG xFETjvJwH1BYAHdMKxxFr7r3hpwUrdz0r85KnBrBJZXSzfqiBY5nKIMH+scCd9ZirZAb /+qvENFgdlvIJ1apQ6VXW7x+15GNuzAhR/tAA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709585897; x=1710190697; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MBysldzXTflPzomKWRmSMXhF54SNqFAu7g8kqMxzJW8=; b=khhRfUVgGX+Je/ujxMvSWVHpPvyrFESddleH0fMWM+4k0qsaTUgCieSBWWZFomY6jo OnIvOD4Xv8a8LZxyzFoQzSRw1d/ObWzCiiwJcrO57943tgZcKFe4Dnflh3qT7Qn9ve3Z oKjKpcRuglBQWTkjBKdfgr+JDCBaghXGZGa/hPtn5GrZyfx0nuzajuOYmOR/NS9MBeUl CGbrIEe+fslSr7+v79cjNgn5xedr/5gNMIX2sTfluF4HrFT3hk3zI8tv3F7xVQsfI9fb PhMGQNMyJkBpx8pwfKN0KMjdzF8iMhMEmZwtt+l8bReTbnq8Jh3tEmIUaDP46FndAqMf cDuA== X-Forwarded-Encrypted: i=1; AJvYcCUjD+7G+uAMoriXPc73Mk6Jk2vbxleg54PmNM6V/EVHdRe8c5+sXNC8U5ApgpqNWHmkCB/Jj+bJQj1uFqHe6dsFuME0hxyszGP7OBqlEdQm X-Gm-Message-State: AOJu0YwXSMP6q0Cdz9fxZ0zRZgf6cBxQDX5OceCAYDN8nWODz5Bz3kNX tvO3fr6WW1iD2OjcR+Eg+JDby48borA6Wp5q6UAyr3jzRTG01aCAEvjcXIV4vbLxLI+qZkV4z8Y = X-Google-Smtp-Source: AGHT+IHa3YpcV8KFwBIJ1K/azj4a+KW8cW4kPPah4+2gIkxeNC+6+YuYOXOCykzg7xOmrXCDdKZsvA== X-Received: by 2002:a17:902:a3cc:b0:1dc:794e:27b2 with SMTP id q12-20020a170902a3cc00b001dc794e27b2mr10676858plb.56.1709585897109; Mon, 04 Mar 2024 12:58:17 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id jv11-20020a170903058b00b001dc96c5fa13sm8950726plb.295.2024.03.04.12.58.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 12:58:16 -0800 (PST) Date: Mon, 4 Mar 2024 12:58:15 -0800 From: Kees Cook To: Muhammad Usama Anjum Cc: Eric Biederman , Shuah Khan , kernel@collabora.com, kernel-janitors@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] selftest/exec: conform test to TAP format output Message-ID: <202403041256.80EDE9BA2@keescook> References: <20240304155928.1818928-1-usama.anjum@collabora.com> <20240304155928.1818928-2-usama.anjum@collabora.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240304155928.1818928-2-usama.anjum@collabora.com> On Mon, Mar 04, 2024 at 08:59:24PM +0500, Muhammad Usama Anjum wrote: > Conform the layout, informational and status messages to TAP. No > functional change is intended other than the layout of output messages. > > Signed-off-by: Muhammad Usama Anjum > --- > tools/testing/selftests/exec/load_address.c | 34 +++++++++------------ > 1 file changed, 15 insertions(+), 19 deletions(-) > > diff --git a/tools/testing/selftests/exec/load_address.c b/tools/testing/selftests/exec/load_address.c > index d487c2f6a6150..17e3207d34ae7 100644 > --- a/tools/testing/selftests/exec/load_address.c > +++ b/tools/testing/selftests/exec/load_address.c > @@ -5,6 +5,7 @@ > #include > #include > #include > +#include "../kselftest.h" > > struct Statistics { > unsigned long long load_address; > @@ -41,28 +42,23 @@ int main(int argc, char **argv) > unsigned long long misalign; > int ret; > > + ksft_print_header(); > + ksft_set_plan(1); > + > ret = dl_iterate_phdr(ExtractStatistics, &extracted); > - if (ret != 1) { > - fprintf(stderr, "FAILED\n"); > - return 1; > - } > + if (ret != 1) > + ksft_exit_fail_msg("FAILED: dl_iterate_phdr\n"); I'm for this series, but I do note a weird glitch in the ksft API. ksft_exit_fail_msg does: va_start(args, msg); printf("Bail out! "); errno = saved_errno; vprintf(msg, args); va_end(args); "Bail out!" is not very descriptive. I think I'd rather this should be: "FAILED: " and then that added prefix doesn't need to be added everywhere in this patch, nor the "error: " prefix in the next patch. -- Kees Cook