Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Wander Lairson Costa <wander@redhat.com>,
	kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	Brendan Higgins <brendan.higgins@linux.dev>,
	David Gow <davidgow@google.com>,
	Matti Vaittinen <mazziesaccount@gmail.com>,
	Maxime Ripard <mripard@kernel.org>, Rae Moar <rmoar@google.com>,
	Shuah Khan <skhan@linuxfoundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] kunit: avoid memory leak on device register error
Date: Fri, 19 Apr 2024 08:33:30 +0200	[thread overview]
Message-ID: <2024041919-untrimmed-palatable-1350@gregkh> (raw)
In-Reply-To: <b18c2e4b-bf61-41ad-b5f9-8e52d7651cca@web.de>

On Fri, Apr 19, 2024 at 08:15:25AM +0200, Markus Elfring wrote:
> > If the device register fails, free the allocated memory before
> > returning.
> 
> Can a description variant (like the following) be more appropriate?
> 
>    Free the allocated memory (after a device registration failure)
>    before returning.
>    Thus add a jump target so that a bit of exception handling can be better
>    reused at the end of this function implementation.
> 
> 
> Would you like to replace the word “register” by “registration” also
> in the summary phrase?
> 

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot

      reply	other threads:[~2024-04-19  6:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18 21:02 [PATCH v3 0/2] kunit: fix minor error path mistakes Wander Lairson Costa
2024-04-18 21:02 ` [PATCH v3 1/2] kunit: unregister the device on error Wander Lairson Costa
2024-04-19  4:58   ` David Gow
2024-04-19  5:40   ` Markus Elfring
2024-04-19  6:07     ` Greg Kroah-Hartman
2024-04-18 21:02 ` [PATCH v3 2/2] kunit: avoid memory leak on device register error Wander Lairson Costa
2024-04-19  4:58   ` David Gow
2024-04-19 12:30     ` Wander Lairson Costa
2024-04-19 13:59       ` Greg Kroah-Hartman
2024-04-19  6:15   ` Markus Elfring
2024-04-19  6:33     ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024041919-untrimmed-palatable-1350@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Markus.Elfring@web.de \
    --cc=brendan.higgins@linux.dev \
    --cc=davidgow@google.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    --cc=mripard@kernel.org \
    --cc=rmoar@google.com \
    --cc=skhan@linuxfoundation.org \
    --cc=wander@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox