From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70CB6629E6 for ; Tue, 23 Apr 2024 10:56:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713869795; cv=none; b=OooAJ2+15Yk4KMmcKfFpSpAEhefjsGOLDlYUBntSOhdKjHUo6eKZdzZ+NG8PGqCbZcPvlECeFfSdU8FaAygdNt+c0WmvoFFaUl3STOGhthecg5GX/y7jsUCDLCJLkxoIQy3EAk8dh4R7CJJ3FE3+fv4gvg9avZ2oQKd8DPrxOLQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713869795; c=relaxed/simple; bh=o3+E/pVcXMqGN2IqmycMoE4DCLdrwAivCv4tvzqB9Rk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=piKZBBiz2f2sf2Z0kx3oePyvuDfPD6QTLPuQCVL+NC2jKR+XSCeHkgaGybquXZxg8ViJKsQexHTtdBmDi+8qj4NgsN69KGxClfJE2V9yakdyr1tlvEO1MSxx40reWFHTPiF+orccmrCrdZWcfx2mNqOlFqxEM6jnuw4c1K8t4WA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=GWjWXBv7; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="GWjWXBv7" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a51addddbd4so553054966b.0 for ; Tue, 23 Apr 2024 03:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1713869792; x=1714474592; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=f7A3dJbrWY/9z1NTPLr/SP8VA+syiS13CnbQZQzTmh4=; b=GWjWXBv7Cn/wPbJp28rCO/HzDYzjI29GOdYQTrarblqKOgDeYn3CMGmc/GwGIkH4It iB3UMMD6o4gBTSzyTAEtPmdUsIT2n0REd682t2ojxM4ti9Dm/fCioytcnGeCadF8Qcjn BpIBgOr0VFARD/PwKTh7SXuBs8aHgvSqqdh0f42hJm7nDib5NCjiC60yYWVYaaH4MUys D+SXlayKn1e3Do3FKERf/5Gpxhj/xYw+NqF2h6vvfqEx9ZO+s0abjW2tbqyjiCAWdSVl BrPOEbTJ3p9kwUvePL8lXjN2ZBgRJNamoLAcGjwbn8i8Ynaw8PSDXBTbMCdblEqWu7F4 7wCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713869792; x=1714474592; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f7A3dJbrWY/9z1NTPLr/SP8VA+syiS13CnbQZQzTmh4=; b=hZAK67tdH/VfUDKWExrDYI0cmkdGqAOLAqlvmbSRsvmljyD0E6eTtOc0jOia8VVO1L Yeu9iw5tv9GyIUpCH+qEfzmxJJuYVjAx9H6rMErykCTw5XBJyznRgjhoNXuSmWqJrhji Vv2JfxeIwWrtzv1YUIlUhMPTygX5r0pLs4MvwX9JYRWX46HOXQfVDSLz7KAMJc130AF5 B7jE8KVMRuVzcfwjHyzgmdJdtCoLro/UUeEX1DVUd+m0AUj35E5YBVsPKZfit9LRlOOH 35OHjPRe30GJyMOzJBiDNT0ZjNn4Zfay8xh32OGNVqWqYzNBRYRFi3icjIUwRg1MFjgG OXlQ== X-Forwarded-Encrypted: i=1; AJvYcCX9DHPf9IHmbH+IZcmkdcrcMiebwDwFZDhBi2NdagKFlybNEpfAhMohZ8DETyV+U2eRoszao8Nm5lSmIbBqviYPkq9GCg0lLgtC7g2Ma97Q X-Gm-Message-State: AOJu0YwW/JHiNi+802bY0y7jQ3nz2HomGgimn9avo/QptW8QKlqQWaJ8 lBGJk1eAVhA0NC1saQBCPo0ir5YW6q8pbLc6XPitESdR8iIGIWdcFzSrkW6KZ68= X-Google-Smtp-Source: AGHT+IGuxCj+bPVMezQTiiqaIkHubBLsXlhj+D610GPwkEGBc0PyN8R4nZYOrEBNLFuAizVxpXXs2w== X-Received: by 2002:a17:906:3502:b0:a52:22c4:8158 with SMTP id r2-20020a170906350200b00a5222c48158mr8092139eja.56.1713869791624; Tue, 23 Apr 2024 03:56:31 -0700 (PDT) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id c27-20020a170906d19b00b00a5557bc8920sm6916846ejz.54.2024.04.23.03.56.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 03:56:31 -0700 (PDT) Date: Tue, 23 Apr 2024 12:56:30 +0200 From: Andrew Jones To: Muhammad Usama Anjum Cc: Atish Patra , linux-kernel@vger.kernel.org, Ajay Kaher , Albert Ou , Alexandre Ghiti , Anup Patel , samuel.holland@sifive.com, Conor Dooley , Juergen Gross , kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, Mark Rutland , Palmer Dabbelt , Paolo Bonzini , Paul Walmsley , Shuah Khan , virtualization@lists.linux.dev, Will Deacon , x86@kernel.org Subject: Re: [PATCH v8 24/24] KVM: riscv: selftests: Add commandline option for SBI PMU test Message-ID: <20240423-b25d0b1540d2092f5370afa5@orel> References: <20240420151741.962500-1-atishp@rivosinc.com> <20240420151741.962500-25-atishp@rivosinc.com> <724a4797-18dc-4011-ba48-445c1cb6a976@collabora.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <724a4797-18dc-4011-ba48-445c1cb6a976@collabora.com> On Tue, Apr 23, 2024 at 02:03:29PM +0500, Muhammad Usama Anjum wrote: ... > > + pr_info("Usage: %s [-h] [-d ]\n", name); > A little weird that we have pr_info named helper to print logs when it is a > userspace application, not kernel code. I'll check it in the source who > added it to the KVM tests. > It was me, as git-blame will easily show you. Why is it "weird"? Applications have needs for pr_info-like functions too, and the pr_info name isn't reserved for the kernel. The only thing weird I see is that I didn't differentiate pr_debug and pr_info messages. I probably should have at least given pr_debug output a 'debug:' prefix. Thanks, drew