From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9946E2230C for ; Fri, 26 Apr 2024 19:40:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714160436; cv=none; b=HN/KEZCmiUxgk/QEccjMCZDLQBGtObjc2pAQQgh94kOuXI1UYXBotcRg7ISABcLZU717xqho9zQ6gSnP/KA6akrRQShrC3sA5nifUiA/tTiMnXVhfsjKYiCKmFuq6DMYKi8mTtV6PRx8i29OhmBwOXPUNYvQCZB8VMre20iYCjI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714160436; c=relaxed/simple; bh=LcwyKWwPX6z34F0Gb9soBrF9DmV/UB27hHsQADFPmmk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=en/j4VOc1cdxhH9Q39uH16VQJq2eTgjEj5PClIE8JLtMh4LDXW9J3RS734hh+SFjmhUYVwFe1p5cMZvoqPyvlcfttI2Zl0BuObI22XqxMHiNaC4fsUJsQYjMpzuFwSQEYwzk2ehowXd9O+NUZOdOfgJSVeGGEN+BCnWkY9tqmuM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Hil+eIBn; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Hil+eIBn" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-6ecf05fd12fso2350752b3a.2 for ; Fri, 26 Apr 2024 12:40:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714160434; x=1714765234; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=KLztx8KYJnj7bEhi+e9Rs8Zsig7zBXXhW5ZdjWyfVfw=; b=Hil+eIBn1mLXz4OMGsRwfez3O9X0dkL7bAZBdzqaT8xBBAUOznEMC4VkJjMThUbDi6 JyJeyXLFw3+2ojVolbnlEyCs5IVmLnh0qKDyb7Yy3mefTDlcR9J9Q8yUGmBhsi3s2TB9 A4HdofcnvmaZF8MjpDxO2PWLmMA/rLchMR6VY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714160434; x=1714765234; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KLztx8KYJnj7bEhi+e9Rs8Zsig7zBXXhW5ZdjWyfVfw=; b=MhU5wgzAyMNXviFD5si4zyz1VMefDRVX0Pc3OefdPxpgz0K9hUh9i9QHJ6ursJb/np na3vfVRmNftQOJbOJ9muZ+ECACoXK37wzg7rXQ3vGI+BhvOxXIX/ZsC7BRE/ZziADLXS HiNfnQqIbmZVNH37GDDS0X6Q57p7utrhxZQp8n3pyYQ21p4B5pZ6lXGCmXJ0CmnjdNyQ YgYuJJ6fJCuqh+Zm9gfVHyIxpDO3qCfY0QYFH9gYuUbTb6GPvLc7/4nxjAjtmaVJlP2r kbvRSoJYTPqGPbHgYTTUansF16H1HdhJ0RL1I8M25mGMaLT1Sc8hgWhXCA02Z+crW+E/ Assw== X-Forwarded-Encrypted: i=1; AJvYcCUAP8Y1mW4NbijVCyoG3WRt8jnjhLFKTPluDU0mmEaP7yNOhCbvH1HaDxOY3smgACcZS3IjI5oDBsRxA+o2DmBrtFZPTMNJ9Rddy5wavb1C X-Gm-Message-State: AOJu0YyPpBFuE7nBqjopxghySlC0O/f0DZLfTIxC3EtaUGHqJKjFyhvD N+wTIdLw+2sSUg15S1wJkZq/ehPAO+n/D3qNW7zlIPxAO4qoi4mSb30jR5V91w== X-Google-Smtp-Source: AGHT+IEVck8/DhxISBA3th436oPnjrKXPkbS4uqXM8nzquMCPo0gI3q/3yYVFDOH76WDU9eJlzL8Kg== X-Received: by 2002:a05:6a00:22ca:b0:6ed:8798:3fa3 with SMTP id f10-20020a056a0022ca00b006ed87983fa3mr4863802pfj.15.1714160433840; Fri, 26 Apr 2024 12:40:33 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id fc4-20020a056a002e0400b006eb058b2703sm13561886pfb.187.2024.04.26.12.40.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 12:40:32 -0700 (PDT) Date: Fri, 26 Apr 2024 12:40:32 -0700 From: Kees Cook To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: Christian Brauner , Jakub Kicinski , Mark Brown , Shengyu Li , Shuah Khan , "David S . Miller" , =?iso-8859-1?Q?G=FCnther?= Noack , Will Drewry , kernel test robot , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan Subject: Re: [PATCH v1 3/5] selftests/harness: Fix fixture teardown Message-ID: <202404261240.78AD73958@keescook> References: <20240426172252.1862930-1-mic@digikod.net> <20240426172252.1862930-4-mic@digikod.net> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240426172252.1862930-4-mic@digikod.net> On Fri, Apr 26, 2024 at 07:22:50PM +0200, Mickaël Salaün wrote: > Make sure fixture teardowns are run when test cases failed, including > when _metadata->teardown_parent is set to true. > > Make sure only one fixture teardown is run per test case, handling the > case where the test child forks. I had to go look up __sync_bool_compare_and_swap(). :) > > Cc: Shuah Khan > Cc: Shengyu Li > Fixes: 72d7cb5c190b ("selftests/harness: Prevent infinite loop due to Assert in FIXTURE_TEARDOWN") > Fixes: 0710a1a73fb4 ("selftests/harness: Merge TEST_F_FORK() into TEST_F()") > Signed-off-by: Mickaël Salaün > Link: https://lore.kernel.org/r/20240426172252.1862930-4-mic@digikod.net Reviewed-by: Kees Cook -Kees > --- > tools/testing/selftests/kselftest_harness.h | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h > index ba3ddeda24bf..73491efbae9e 100644 > --- a/tools/testing/selftests/kselftest_harness.h > +++ b/tools/testing/selftests/kselftest_harness.h > @@ -383,7 +383,10 @@ > FIXTURE_DATA(fixture_name) self; \ > pid_t child = 1; \ > int status = 0; \ > - bool jmp = false; \ > + /* Makes sure there is only one teardown, even when child forks again. */ \ > + bool *teardown = mmap(NULL, sizeof(*teardown), \ > + PROT_READ | PROT_WRITE, MAP_SHARED | MAP_ANONYMOUS, -1, 0); \ > + *teardown = false; \ > memset(&self, 0, sizeof(FIXTURE_DATA(fixture_name))); \ > if (setjmp(_metadata->env) == 0) { \ > /* Use the same _metadata. */ \ > @@ -400,15 +403,16 @@ > _metadata->exit_code = KSFT_FAIL; \ > } \ > } \ > - else \ > - jmp = true; \ > if (child == 0) { \ > - if (_metadata->setup_completed && !_metadata->teardown_parent && !jmp) \ > + if (_metadata->setup_completed && !_metadata->teardown_parent && \ > + __sync_bool_compare_and_swap(teardown, false, true)) \ > fixture_name##_teardown(_metadata, &self, variant->data); \ > _exit(0); \ > } \ > - if (_metadata->setup_completed && _metadata->teardown_parent) \ > + if (_metadata->setup_completed && _metadata->teardown_parent && \ > + __sync_bool_compare_and_swap(teardown, false, true)) \ > fixture_name##_teardown(_metadata, &self, variant->data); \ > + munmap(teardown, sizeof(*teardown)); \ > if (!WIFEXITED(status) && WIFSIGNALED(status)) \ > /* Forward signal to __wait_for_test(). */ \ > kill(getpid(), WTERMSIG(status)); \ > -- > 2.44.0 > -- Kees Cook